Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_1_X] Update utilities for SimBeamSpotObjects handling #41940

Merged
merged 9 commits into from
Jun 13, 2023

Conversation

francescobrivio
Copy link
Contributor

PR description:

Verbatim Backport of #41918

Update utilities to write and read SimBeamSpotObjects payloads - see master PR for details.

PR validation:

See master PR

Backport:

Backport of #41918

@francescobrivio
Copy link
Contributor Author

backport of #41918

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 13, 2023

A new Pull Request was created by @francescobrivio for CMSSW_13_1_X.

It involves the following packages:

  • CondCore/BeamSpotPlugins (db)
  • CondCore/Utilities (db)
  • CondFormats/BeamSpotObjects (db, alca)
  • CondTools/BeamSpot (db, alca)
  • IOMC/EventVertexGenerators (simulation)

@civanch, @mdhildreth, @cmsbuild, @saumyaphor4252, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@grzanka, @mmusich, @seemasharmafnal, @tocheng, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-002eb9/33116/summary.html
COMMIT: efca3b9
CMSSW: CMSSW_13_1_X_2023-06-12-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41940/33116/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3221591
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3221566
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Jun 13, 2023

+1

@civanch
Copy link
Contributor

civanch commented Jun 13, 2023

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 83835cb into cms-sw:CMSSW_13_1_X Jun 13, 2023
@francescobrivio francescobrivio deleted the alca-simBS_13_1_X branch June 16, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants