-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a comparison plot on two tags for JetMET JEC PI #41906
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41906/35855
|
A new Pull Request was created by @yuanchao (Yuan CHAO) for master. It involves the following packages:
@cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove commented out code
CondCore/JetMETPlugins/plugins/JetCorrector_PayloadInspector.cc
Outdated
Show resolved
Hide resolved
CondCore/JetMETPlugins/plugins/JetCorrector_PayloadInspector.cc
Outdated
Show resolved
Hide resolved
CondCore/JetMETPlugins/plugins/JetCorrector_PayloadInspector.cc
Outdated
Show resolved
Hide resolved
CondCore/JetMETPlugins/plugins/JetCorrector_PayloadInspector.cc
Outdated
Show resolved
Hide resolved
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41906/35859
|
Pull request #41906 was updated. @cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please check and sign again. |
@cmsbuild , please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-64f392/33069/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Requested during the AlCa meeting on May 8, adding comparison plots for two different tags JetCorrector payload inspector. Correction level and jet parameters can be set through the input parameter interface of PI.
PR validation:
Local tests with getPayloadData.py script.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This is not a backport.