Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dqm-* scripts for python3. #41893

Merged
merged 1 commit into from
Jun 10, 2023
Merged

Conversation

rovere
Copy link
Contributor

@rovere rovere commented Jun 7, 2023

PR description:

Fix dqm-access, dqm-ls and dqm-grep scripts to work with python3.

PR validation:

Locally tested the scripts.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41893/35833

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2023

A new Pull Request was created by @rovere (Marco Rovere) for master.

It involves the following packages:

  • DQMServices/Components (dqm)

@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@rovere
Copy link
Contributor Author

rovere commented Jun 7, 2023

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-68a896/33035/summary.html
COMMIT: 4cb474b
CMSSW: CMSSW_13_2_X_2023-06-07-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41893/33035/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 15 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3219909
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3219885
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 479dd5c into cms-sw:master Jun 10, 2023
@mmusich
Copy link
Contributor

mmusich commented Jun 10, 2023

@rovere thanks for this! Are there plans to backport (e.g. to 13.0.X)?

@rovere
Copy link
Contributor Author

rovere commented Jun 15, 2023

@mmusich probably a backport could be as easy as applying the same patch on top of that branch...?

@mmusich
Copy link
Contributor

mmusich commented Jun 15, 2023

probably a backport could be as easy as applying the same patch on top of that branch...?

@rovere of course it can. If you don't have time or will to do it, I can jump in, just checking...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants