Small fix to DTDataIntegrityTask.cc

[perrotta]

PR description:

The Static Analyzer for DQM/DTMonitorModule/src/DTDataIntegrityTask.cc warns that at line 669 there is a C++ object whose pointer is potentially null

The reason is that the uROSSummary (as well as the uROSStatus) objects are only instantiated when mode<=2, while in that line it is accessed for every mode != 1.

Here the check mode<=2 is extended also to the filling of those Monitor Elements

PR validation:

It builds
No changes expected: at most, the previous version could have crashed if mode>2

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41892/35832

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @perrotta (Andrea Perrotta) for master.

It involves the following packages:

• DQM/DTMonitorModule (dqm)

@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@battibass this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[perrotta]

@battibass

[perrotta]

please test

[battibass]

Thanks @perrotta.
To me looks OK, but the last one updating the DTDataIntegrityTask.cc logic was @jfernan2, so I kindly ask him to have a final word.

[jfernan2]

Hi,
thanks @perrotta !
I believe the change is perfect. We never saw the crash since the only mode which could have produced it (mode=3) is barely used.
Thanks

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2697da/33036/summary.html
COMMIT: afe44bf
CMSSW: CMSSW_13_2_X_2023-06-07-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41892/33036/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 12 lines from the logs
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3219909
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3219887
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1