Remove stripTrackerHVOn check for BeamSpotLegacy client

[francescobrivio]

PR description:

Recently we had an issue in Fill 8860 when the TEC- DCS bit was marked as HV OFF (see here) because the ON channels were 95% as far as I understood (and the majority is set to 98% of channels).

Hence the BeamSpot was not computed by the neither of the clients for the affected runs, see here.

We also realized that, since the beam client (BeamSpotLegacy) is only relying on pixel tracks and vertices, this check is not only useless, but actually detrimental in cases like this.

This PR removes the check on the SiStrip HV for the beam DQM BeamSpot client.

PR validation:

Running this command:

cmsRun DQM/Integration/python/clients/beam_dqm_sourceclient-live_cfg.py unitTest=True runNumber=368341 dataset=/ExpressPhysics/Run2023C-Express-v4/FEVT

before the fix leads to (no BeamSpot):

-rw-r--r--. 1 fbrivio zh    0 Jun  5 15:37 BeamFitResultsOld.txt
-rw-r--r--. 1 fbrivio zh    0 Jun  5 15:37 BeamSpotOnlineLegacy.db

While after this PR the BeamSpot is computed:

-rw-r--r--. 1 fbrivio zh  4220 Jun  2 18:28 2023-06-02_16-28-37.log
-rw-r--r--. 1 fbrivio zh   674 Jun  2 18:27 BeamFitResultsOld.txt
-rw-r--r--. 1 fbrivio zh    85 Jun  2 18:27 BeamFitResultsOld_TkStatus.txt
-rw-r--r--. 1 fbrivio zh 65536 Jun  2 18:27 BeamSpotOnlineLegacy.db

Backport:

Not a backport. Backports to 13_1_X and 13_2_X are available in:

• 13_1_X: [13_1_X] Remove stripTrackerHVOn check for BeamSpotLegacy client #41882
• 13_0_X: [13_0_X] Remove stripTrackerHVOn check for BeamSpotLegacy client #41883

FYI @mmusich @dzuolo @gennai @lguzzi

[francescobrivio]

@cmsbuild please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41875/35790

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

• DQM/Integration (dqm)

@nothingface0, @emanueleusai, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@threus, @batinkov this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3f40b8/32995/summary.html
COMMIT: a0e24b9
CMSSW: CMSSW_13_2_X_2023-06-05-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41875/32995/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 14 lines to the logs
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3219909
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3219881
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1