-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move events/LS counter to LuminosityBlockCache in DTDataIntegrityTask #41874
Move events/LS counter to LuminosityBlockCache in DTDataIntegrityTask #41874
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41874/35785
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages:
@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-55066e/32988/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
@cms-sw/dqm-l2 Does this need to be backported to 13_0_X? |
+1 |
PR description:
This PR is part of #37163. It makes
DTDataIntegrityTask
concurrent-lumi-safe (as far as I can tell) by moving the counter for the number of events per lumi to LuminosityBlockCache. Earlier the counter could have counted events from other lumis and being reset to 0 in the middle of a lumi when concurrent lumis are enabled.PR validation:
Code compiles.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
If this DQM module is used in offline DQM run in Tier0, I'd backport to 13_0_X.