Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ReweightUserHooks.h #41850

Merged
merged 2 commits into from
Jun 2, 2023
Merged

Update ReweightUserHooks.h #41850

merged 2 commits into from
Jun 2, 2023

Conversation

menglu21
Copy link
Contributor

@menglu21 menglu21 commented Jun 2, 2023

PR description:

Update 13000 to 13600 in ReweightUserHooks.h for Run3

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

backport of #41836, needed for run3 production using this release

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2023

A new Pull Request was created by @menglu21 (Meng_Lu) for CMSSW_13_1_X.

It involves the following packages:

  • GeneratorInterface/Pythia8Interface (generators)

@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @alberto-sanchez, @menglu21, @GurpreetSinghChahal can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@menglu21
Copy link
Contributor Author

menglu21 commented Jun 2, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2023

Pull request #41850 was updated. @SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @alberto-sanchez, @menglu21, @GurpreetSinghChahal can you please check and sign again.

@menglu21
Copy link
Contributor Author

menglu21 commented Jun 2, 2023

please test

@perrotta
Copy link
Contributor

perrotta commented Jun 2, 2023

backport of #41836

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2354ed/32948/summary.html
COMMIT: 2650714
CMSSW: CMSSW_13_1_X_2023-06-01-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41850/32948/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3221591
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3221563
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@Saptaparna
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f1597d9 into cms-sw:CMSSW_13_1_X Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants