Update muon (un)packer with support for fixed uGMT firmware

[dinyar]

PR description:

Update to the muon unpacker to support a coming uGMT firmware version that places the two loose muon shower bit on a different link. The change is necessary due to a miscommunication between uGT and uGMT teams.

This should go to P5, so I plan on making a backport to 13_0_X, however could you let me know if a packport to 13_1_X is also necessary?

PR validation:

Ran standard tests.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41844/35745

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @dinyar (Dinyar Rabady) for master.

It involves the following packages:

• EventFilter/L1TRawToDigi (l1)
• L1Trigger/L1TMuon (l1)

@epalencia, @cmsbuild, @aloeliger can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @JanFSchulte, @thomreis, @eyigitba this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[epalencia]

Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f3b4db/32934/summary.html
COMMIT: 98b7c26
CMSSW: CMSSW_13_2_X_2023-06-01-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41844/32934/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 31 lines to the logs
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3221457
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3221426
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[aloeliger]

@dinyar I think a port to 13_1 is not a terrible, as per the release notes:

If needed, it can be used for a partial ReRECO and become T0 data taking release

I think better safe than forgotten in case of need in this scenario for a small change.

[aloeliger]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[dinyar]

Ok, thanks for letting me know! Did so in #41855 and #41856

[rappoccio]

+1