Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_1_X] New EMTF BDT pT scale for 2023 #41840

Merged
merged 1 commit into from
Jun 4, 2023

Conversation

eyigitba
Copy link
Contributor

@eyigitba eyigitba commented Jun 1, 2023

PR description:

This PR adds support for the new EMTF BDT pT scale for 2023. The new LUTs are deployed at P5 starting from run 367661. The new LUT version with lower scale factor is ptLUTVersion_ = 9.

There is no change in behaviour when using the older versions of pT LUTs.

This PR is required for correct re-emulation of data and it will improve the data/emulator mismatch rate in DQM.

This is a backport of #41835

PR validation:

Tested by unpacking recent data to make sure the correct ptLUTVersion_ is triggering the new scale factors.

Also validated with runTheMatrix.py -l limited -i all --ibeos, no failures.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #41835

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2023

A new Pull Request was created by @eyigitba for CMSSW_13_1_X.

It involves the following packages:

  • L1Trigger/L1TMuonEndCap (l1)

@epalencia, @cmsbuild, @aloeliger can you please review it and eventually sign? Thanks.
@dinyar, @missirol, @JanFSchulte, @thomreis, @Martin-Grunewald this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@aloeliger
Copy link
Contributor

Backport of #41835

@aloeliger
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-56bfcd/32929/summary.html
COMMIT: 7bf4737
CMSSW: CMSSW_13_1_X_2023-06-01-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41840/32929/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 8 lines from the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3221591
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3221563
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@aloeliger
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Jun 4, 2023

+1

@cmsbuild cmsbuild merged commit 97a64af into cms-sw:CMSSW_13_1_X Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants