Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilities/StaticAnalyzers: Remove postprocess-scan-build.py script no longer needed. #41833

Merged

Conversation

gartung
Copy link
Member

@gartung gartung commented May 31, 2023

Starting with llvm/clang 16, the static analyzer removes bug reports for duplicate locations. The postprocess-scan-build.py script is no longer needed to do this.

addresses #41828

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41833/35727

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for master.

It involves the following packages:

  • Utilities/StaticAnalyzers (core)

@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@gartung
Copy link
Member Author

gartung commented May 31, 2023

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ce182b/32910/summary.html
COMMIT: 9a52cb0
CMSSW: CMSSW_13_2_X_2023-05-31-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41833/32910/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3221457
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3221429
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor

makortel commented Jun 1, 2023

Given that this PR only removes a script, is a corresponding change to remove calling the script (only for 13_2_X onwards) needed somewhere? Or is the calling side "smart" enough to call the script only if it exists?

@gartung
Copy link
Member Author

gartung commented Jun 1, 2023

The calling script checks if the file exists and runs it.

@makortel
Copy link
Contributor

makortel commented Jun 1, 2023

+core

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Jun 1, 2023

+1

@cmsbuild cmsbuild merged commit 686037e into cms-sw:master Jun 1, 2023
@gartung
Copy link
Member Author

gartung commented Jun 8, 2023

@makortel can this be back-ported to CMSSW_13_1_X?

@makortel
Copy link
Contributor

makortel commented Jun 8, 2023

I'd be fine with the backport.

@gartung
Copy link
Member Author

gartung commented Jun 8, 2023

I think a level 1 or level 2 has to issue the backport command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants