-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DAQ] improved file size/buffer size checks in DAQ input source (13_2_X) #41814
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41814/35699
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
e3fd0d4
to
dbc336a
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41814/35700
|
A new Pull Request was created by @smorovic (Srecko Morovic) for master. It involves the following packages:
@cmsbuild, @emeschi, @smorovic can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0bb0d2/32875/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Improved file size limit checks in input sources. Print more debug info when waiting for a buffer.
PR validation:
Retested in DAQ test cluster and covered also by unit tests.