Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.1.X] Migrate DiMuonMassBiasClient mass bias histograms to profiles #41781

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented May 27, 2023

backport of #41779

PR description:

The main goal of this PR is to migrate the underlying ROOT type of the di-muon mass bias ME produced by DiMuonMassBiasClient from being TH1-s to TProfile-s. This would solve the visualization issues when displaying these in the GUI overlaid with a previous run.
I leave the possibility to produce histograms instead via a dedicated configuration flag, since that might be useful when run in standalone mode. Additionally I restrict the range of the μμ pair Δη for the Z→μμ case.

PR validation:

I've run successfully the unit tests of this packages via scram b runtests_testDiMuonVertexMonitor use-ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #41779 as intermediate step toward 13.0.X (needed for 2023 data-taking)

@cmsbuild
Copy link
Contributor

cmsbuild commented May 27, 2023

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_1_X.

It involves the following packages:

  • DQMOffline/Alignment (dqm)

@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented May 27, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-337389/32830/summary.html
COMMIT: 37ecc1b
CMSSW: CMSSW_13_1_X_2023-05-26-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41781/32830/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 8 lines from the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3221591
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3221563
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2fcc6f8 into cms-sw:CMSSW_13_1_X May 28, 2023
@mmusich mmusich deleted the migrate_DiMuonMassBiasClient_to_Profiles_13_1_X branch May 28, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants