[DBG_X] Fix error in HGCalTestGuardRing.cc #41778

iarspider · 2023-05-26T08:44:09Z

PR description:

This PR fixes build errors introduced by #41756:

>> Compiling bigobj edm plugin /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/02a7881e88394d2e0343aaa70ceddda0/opt/cmssw/el8_amd64_gcc11/cms/cmssw/CMSSW_13_2_DBG_X_2023-05-25-2300/src/SimG4CMS/Calo/plugins/CaloSteppingAction.cc
/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc11/external/gcc/11.2.1-f9b9dfdd886f71cd63f5538223d8f161/bin/c++ -c -DGNU_GCC -D_GNU_SOURCE -DEIGEN_DONT_PARALLELIZE -DTBB_USE_GLIBCXX_VERSION=110201 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DGNU_GCC -DG4V9 -DGNU_GCC -DG4V9 -DDD4HEP_USE_GEANT4_UNITS=1 -DCMSSW_GIT_HASH='CMSSW_13_2_DBG_X_2023-05-25-2300' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_13_2_DBG_X_2023-05-25-2300' -I/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/02a7881e88394d2e0343aaa70ceddda0/opt/cmssw/el8_amd64_gcc11/cms/cmssw/CMSSW_13_2_DBG_X_2023-05-25-2300/src -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc11/external/dd4hep/v01-23x-d97a6baacee20309566b7aaf755762c5/include -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc11/external/geant4/11.1.1-ac161db70c0e3e3108ae225f93d223a6/include/Geant4 -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc11/external/geant4/11.1.1-ac161db70c0e3e3108ae225f93d223a6/include -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc11/external/pcre/8.43-5dcc901acc02f624b22dd9840b2357e8/include -isystem/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc11/external/boost/1.80.0-7f4aeae1bffcf24aa4723f09435633c2/include -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc11/external/bz2lib/1.0.6-2c1f18484cb66c30aba7929f2be5e7d4/include -isystem/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc11/external/clhep/2.4.6.0-a4e46555f840df7cd8747ba64c6e914f/include -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc11/external/cuda/11.5.2-66a9473808e7d5863d5bbec0824e2c4a/include -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc11/external/expat/2.1.0-5f6457b4c04e97afec6079bd7d2db998/include -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc11/external/gsl/2.6-fcf47bcbedd800ca8386c7e2920fa474/include -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc11/external/hepmc/2.06.10-8d052e96205063f65fddfc4cbf40f506/include -isystem/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc11/external/hls/2019.08-fd724004387c2a6770dc3517446d30d9/include -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc11/external/libuuid/2.34-0451b31e1b9a58c6aeefab41c18eea34/include -isystem/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc11/lcg/root/6.26.11-9720c7273eac1c892ddadde973cf1965/include -isystem/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc11/external/tbb/v2021.8.0-4e779f195a25a0aba119b27519937ba0/include -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc11/cms/vdt/0.4.3-b2ab7c000c16e419f85e9fb6284d3681/include -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc11/external/vecgeom/v1.2.1-d92ce96afe8fcfdf821b0e3277815aae/include -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc11/external/vecgeom/v1.2.1-d92ce96afe8fcfdf821b0e3277815aae/include/VecGeom -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc11/external/xerces-c/3.1.3-96261f23c7d6fbfb7d59be544bd882f3/include -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc11/external/xz/5.2.5-83d0a00b575efd1701e07bedf7977343/include -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc11/external/zlib/1.2.11-3dfb2715f3608466b74431b80eb9d788/include -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc11/external/eigen/82dd3710dac619448f50331c1d6a35da673f764a-9ac4aed18ac60d0189693c592862694d/include/eigen3 -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc11/external/fmt/8.0.1-43b841663c2a0d6622910a1ad66d228d/include -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc11/external/hepmc3/3.2.5-a8c3d3d81a1b670617f2caa48c1801ef/include -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc11/external/md5/1.0.0-e68283f2de2e2e709a0db99db3b53205/include -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc11/external/OpenBLAS/0.3.15-26c67b8b638762cfd2e2bcfc936e3ec7/include -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc11/external/tinyxml2/6.2.0-c2bad61e58f94d6db8f640afbd739be2/include -O2 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++17 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -fuse-ld=bfd -msse3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-deprecated-copy -Wno-unused-parameter -Wunused -Wparentheses -Wno-deprecated -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-error=unused-variable -ftls-model=global-dynamic -pthread -DBOOST_DISABLE_ASSERTS -g -O3 -DEDM_ML_DEBUG -flto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -Wl,--exclude-libs,ALL  -fPIC   /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/02a7881e88394d2e0343aaa70ceddda0/opt/cmssw/el8_amd64_gcc11/cms/cmssw/CMSSW_13_2_DBG_X_2023-05-25-2300/src/SimG4CMS/Calo/plugins/CaloSteppingAction.cc -o tmp/el8_amd64_gcc11/src/SimG4CMS/Calo/plugins/SimG4CMSCaloPlugins/bigobj/CaloSteppingAction.cc.o
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/02a7881e88394d2e0343aaa70ceddda0/opt/cmssw/el8_amd64_gcc11/cms/cmssw/CMSSW_13_2_DBG_X_2023-05-25-2300/src/SimG4CMS/Calo/plugins/HGCalTestGuardRing.cc: In constructor 'HGCalTestGuardRing::HGCalTestGuardRing(const edm::ParameterSet&)':
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/02a7881e88394d2e0343aaa70ceddda0/opt/cmssw/el8_amd64_gcc11/cms/cmssw/CMSSW_13_2_DBG_X_2023-05-25-2300/src/SimG4CMS/Calo/plugins/HGCalTestGuardRing.cc:108:105: error: no match for 'operator>>' (operand types are 'edm::Log<edm::level::Info, true>::ThisLog' {aka 'edm::Log<edm::level::Info, true>'} and 'int')
   108 |           edm::LogVerbatim("HGCalSim") << "HGCalTestGuardRing::Reads " << id << " Orientatoin:Partial " >> orient >>
      |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^~ ~~~~~~
      |                                                                              |                             |
      |                                                                              |                             int
      |                                                                              edm::Log<edm::level::Info, true>::ThisLog {aka edm::Log<edm::level::Info, true>}

PR validation:

Bot tests

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport

iarspider · 2023-05-26T08:51:55Z

please test for CMSSW_13_2_DBG_X

cmsbuild · 2023-05-26T08:52:05Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41778/35650

This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41778/35650/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41778/35650/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2023-05-26T09:01:18Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41778/35652

This PR adds an extra 12KB to repository

cmsbuild · 2023-05-26T09:01:42Z

A new Pull Request was created by @iarspider for master.

It involves the following packages:

SimG4CMS/Calo (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@felicepantaleo, @rovere, @bsunanda, @thomreis, @wang0jin, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

iarspider · 2023-05-26T09:04:05Z

please test for CMSSW_13_2_DBG_X

iarspider · 2023-05-26T09:04:45Z

please test

iarspider · 2023-05-26T10:07:39Z

please test

cmsbuild · 2023-05-26T12:56:14Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46bcd3/32822/summary.html
COMMIT: 83f2ba7
CMSSW: CMSSW_13_2_X_2023-05-25-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41778/32822/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@smuzaffar [DQM] clang-tidy Performance inefficient vector operation suggestion applied #41766
@bsunanda Phase2-hgx339Z Correct mousebite in case one has both mouebite and guard ring removal for HGCal silicon hits #41772
@brunolopesbr2 Remove gen refitted SA muons #41746

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46bcd3/32822/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46bcd3/32822/git-merge-result

Comparison Summary

Summary:

You potentially added 16 lines to the logs
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3221457
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3221432
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -41.758 KiB( 47 files compared)
DQMHistoSizes: changed ( 12434.0,... ): -20.879 KiB HLT/Exotica
Checked 207 log files, 159 edm output root files, 48 DQM output files
TriggerResults: no differences found

cmsbuild · 2023-05-26T16:36:05Z

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46bcd3/32820/summary.html
COMMIT: 83f2ba7
CMSSW: CMSSW_13_2_DBG_X_2023-05-25-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41778/32820/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46bcd3/32820/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46bcd3/32820/git-merge-result

RelVals

23234.0

----- Begin Fatal Exception 26-May-2023 17:16:20 CEST-----------------------
An exception of category 'Invalid DetId' occurred while
   [0] Calling method for module HGCalBackendLayer1Producer/'l1tHGCalBackEndLayer1Producer'
   [1] Prefetching for EventSetup module HGCalTriggerGeometryESProducer/'l1tHGCalTriggerGeometryESProducer'
   [2] Calling method for EventSetup module HGCalGeometryESProducer/'HFNoseGeometryESProducer'
Exception Message:
Cannot initialize HGCSiliconDetId from 6c8bd800
----- End Fatal Exception -------------------------------------------------

SimG4CMS/Calo/plugins/HGCalTestGuardRing.cc

cmsbuild · 2023-05-27T08:32:42Z

Pull request #41778 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

cmsbuild · 2023-05-27T08:46:51Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41778/35658

This PR adds an extra 16KB to repository

cmsbuild · 2023-05-27T08:47:15Z

Pull request #41778 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

iarspider · 2023-05-27T09:41:17Z

please test for CMSSW_13_2_DBG_X

cmsbuild · 2023-05-27T18:06:51Z

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46bcd3/32833/summary.html
COMMIT: ed66d6e
CMSSW: CMSSW_13_2_DBG_X_2023-05-25-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41778/32833/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46bcd3/32833/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46bcd3/32833/git-merge-result

RelVals

23234.0

----- Begin Fatal Exception 27-May-2023 19:04:29 CEST-----------------------
An exception of category 'Invalid DetId' occurred while
   [0] Calling method for module HGCalBackendLayer1Producer/'l1tHGCalBackEndLayer1Producer'
   [1] Prefetching for EventSetup module HGCalTriggerGeometryESProducer/'l1tHGCalTriggerGeometryESProducer'
   [2] Calling method for EventSetup module HGCalGeometryESProducer/'HFNoseGeometryESProducer'
Exception Message:
Cannot initialize HGCSiliconDetId from 6c8bd800
----- End Fatal Exception -------------------------------------------------

iarspider · 2023-05-28T08:54:24Z

RelVal failure also happens without this patch, as reported in #41088

civanch · 2023-05-28T10:59:00Z

+1

problem in testing does not connect with this PR. The fix is obvious and this PR may be merged.

cmsbuild · 2023-05-28T10:59:25Z

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2023-05-28T11:19:53Z

+1

perrotta · 2023-05-28T11:19:59Z

merge

cmsbuild added this to the CMSSW_13_2_X milestone May 26, 2023

cmsbuild added simulation-pending pending-signatures tests-pending orp-pending code-checks-pending labels May 26, 2023

cmsbuild added tests-started code-checks-rejected tests-pending code-checks-pending and removed tests-pending code-checks-pending tests-started code-checks-rejected labels May 26, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels May 26, 2023

cmsbuild added tests-started and removed tests-pending labels May 26, 2023

cmsbuild added tests-approved and removed tests-started labels May 26, 2023

civanch reviewed May 26, 2023

View reviewed changes

SimG4CMS/Calo/plugins/HGCalTestGuardRing.cc Outdated Show resolved Hide resolved

cmsbuild added code-checks-approved and removed code-checks-pending labels May 27, 2023

[DBG_X] Fix error in HGCalTestGuardRing.cc

ed66d6e

iarspider force-pushed the patch-7 branch from aacd1c6 to ed66d6e Compare May 27, 2023 08:38

cmsbuild added code-checks-pending and removed code-checks-approved labels May 27, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels May 27, 2023

cmsbuild added tests-started and removed tests-pending labels May 27, 2023

cmsbuild added tests-rejected and removed tests-started labels May 27, 2023

cmsbuild added simulation-approved fully-signed and removed simulation-pending pending-signatures labels May 28, 2023

cmsbuild added orp-approved and removed orp-pending labels May 28, 2023

cmsbuild merged commit db21679 into cms-sw:master May 28, 2023

iarspider deleted the patch-7 branch May 28, 2023 18:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DBG_X] Fix error in HGCalTestGuardRing.cc #41778

[DBG_X] Fix error in HGCalTestGuardRing.cc #41778

iarspider commented May 26, 2023 •

edited

Loading

iarspider commented May 26, 2023

cmsbuild commented May 26, 2023

cmsbuild commented May 26, 2023

cmsbuild commented May 26, 2023

iarspider commented May 26, 2023

iarspider commented May 26, 2023

iarspider commented May 26, 2023

cmsbuild commented May 26, 2023

cmsbuild commented May 26, 2023

cmsbuild commented May 27, 2023

cmsbuild commented May 27, 2023

cmsbuild commented May 27, 2023

iarspider commented May 27, 2023

cmsbuild commented May 27, 2023

iarspider commented May 28, 2023

civanch commented May 28, 2023

cmsbuild commented May 28, 2023

perrotta commented May 28, 2023

perrotta commented May 28, 2023

[DBG_X] Fix error in HGCalTestGuardRing.cc #41778

[DBG_X] Fix error in HGCalTestGuardRing.cc #41778

Conversation

iarspider commented May 26, 2023 • edited Loading

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

iarspider commented May 26, 2023

cmsbuild commented May 26, 2023

cmsbuild commented May 26, 2023

cmsbuild commented May 26, 2023

iarspider commented May 26, 2023

iarspider commented May 26, 2023

iarspider commented May 26, 2023

cmsbuild commented May 26, 2023

Comparison Summary

cmsbuild commented May 26, 2023

RelVals

cmsbuild commented May 27, 2023

cmsbuild commented May 27, 2023

cmsbuild commented May 27, 2023

iarspider commented May 27, 2023

cmsbuild commented May 27, 2023

RelVals

iarspider commented May 28, 2023

civanch commented May 28, 2023

cmsbuild commented May 28, 2023

perrotta commented May 28, 2023

perrotta commented May 28, 2023

iarspider commented May 26, 2023 •

edited

Loading