Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1T demonstrator tools: Support for EMP v0.7.x buffer file format #41768

Conversation

tswilliams
Copy link
Contributor

PR description:

This pull request extends the existing phase-2 L1T buffer I/O buffer text file utilities by adding support for the new format for data files from the EMP firmware/software framework. No existing functionality is removed - the new EMP buffer file format is simply added as a new option. The new EMP framework version that requires this buffer format is already being used for firmware builds for the phase-2 L1T correlator, GTT and GT.

PR validation:

The following checks have been run on this code (beyond confirming that the code compiles):

  • Ran scram b code-checks and scram b code-format.
  • Ran test/gtt/createFirmwareInputFiles_cfg.py with format set to EMPv2 and inspected output files to verify their format.
  • Ran test/gtt/verifyFirmwareOutput_cfg.py to confirm that the new test/gtt/example_*.txt files were parsed correctly

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41768/35634

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @tswilliams (Tom Williams) for master.

It involves the following packages:

  • L1Trigger/DemonstratorTools (l1)

@epalencia, @cmsbuild, @cecilecaillol, @aloeliger can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@gpetruc
Copy link
Contributor

gpetruc commented May 24, 2023

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dbdb30/32780/summary.html
COMMIT: 5a2215b
CMSSW: CMSSW_13_2_X_2023-05-24-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41768/32780/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 21 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3221591
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3221566
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@aloeliger
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants