-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L1T demonstrator tools: Support for EMP v0.7.x buffer file format #41768
L1T demonstrator tools: Support for EMP v0.7.x buffer file format #41768
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41768/35634
|
A new Pull Request was created by @tswilliams (Tom Williams) for master. It involves the following packages:
@epalencia, @cmsbuild, @cecilecaillol, @aloeliger can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dbdb30/32780/summary.html Comparison SummarySummary:
|
+l1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This pull request extends the existing phase-2 L1T buffer I/O buffer text file utilities by adding support for the new format for data files from the EMP firmware/software framework. No existing functionality is removed - the new EMP buffer file format is simply added as a new option. The new EMP framework version that requires this buffer format is already being used for firmware builds for the phase-2 L1T correlator, GTT and GT.
PR validation:
The following checks have been run on this code (beyond confirming that the code compiles):
scram b code-checks
andscram b code-format
.test/gtt/createFirmwareInputFiles_cfg.py
with format set toEMPv2
and inspected output files to verify their format.test/gtt/verifyFirmwareOutput_cfg.py
to confirm that the new test/gtt/example_*.txt files were parsed correctly