DQM: Online mode for DQMStore #41736

jfernan2 · 2023-05-19T18:26:49Z

PR description:

After the merging of #41400 and its master PR version, some plots[0-3] in Online DQM started misbehaving due to the change of scope introduced by perLS.

This PR tries to distangle Online and Offline modes for DQMStore to avoid such problem

[0] https://github.com/cms-sw/cmssw/blob/master/DQMServices/Core/python/nanoDQMIO_perLSoutput_cff.py#L29-L31
[1] https://github.com/cms-sw/cmssw/blob/master/DQMServices/Core/python/nanoDQMIO_perLSoutput_cff.py#L89-L106
[2] https://github.com/jfernan2/cmssw/blob/5053a4c9343a94ed630a8f824a76f01c3618708f/DQMServices/Core/python/nanoDQMIO_perLSoutput_cff.py#L35-L56
[3] https://github.com/jfernan2/cmssw/blob/5053a4c9343a94ed630a8f824a76f01c3618708f/DQMServices/Core/python/nanoDQMIO_perLSoutput_cff.py#L58-L70

PR validation:

Successfully tested in DQM Online playback, not affecting Offline

cmsbuild · 2023-05-19T18:34:55Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41736/35602

This PR adds an extra 32KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41736/35602/code-checks.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41736/35602/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly
code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41736/35602/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41736/35602/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2023-05-21T10:30:32Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41736/35605

This PR adds an extra 32KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41736/35605/code-checks.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41736/35605/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly

cmsbuild · 2023-05-21T11:46:12Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41736/35606

This PR adds an extra 32KB to repository

cmsbuild · 2023-05-21T11:46:36Z

A new Pull Request was created by @jfernan2 for master.

It involves the following packages:

DQM/Integration (dqm)
DQMServices/Core (dqm)

@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@barvic, @battibass, @threus, @batinkov, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

perrotta · 2023-05-23T09:39:23Z

please test

cmsbuild · 2023-05-23T13:23:50Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f830fd/32754/summary.html
COMMIT: 30c805e
CMSSW: CMSSW_13_2_X_2023-05-22-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41736/32754/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 21 lines from the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3221591
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3221569
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 207 log files, 159 edm output root files, 48 DQM output files
TriggerResults: no differences found

perrotta · 2023-05-23T19:09:26Z

urgent
(because the 13_0_X backport is said to be urgent too)

emanueleusai · 2023-05-24T10:55:58Z

+1

cmsbuild · 2023-05-24T10:56:17Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2023-05-24T12:33:48Z

DQMServices/Core/interface/DQMStore.h

@@ -753,6 +753,8 @@ namespace dqm {
      void debugTrackME(const char* message, MonitorElement* me_local, MonitorElement* me_global) const;
      // accesor to keep MEsToSave_ private
      const auto& getMEsToSave() const { return MEsToSave_; }
+      // accesor to keep onlineMode_ private
+      const bool& getMode() const { return onlineMode_; }


I would have rather called the method getOnlineMode() , or onlineMode(), so that the following line can become more understandable:
https://github.com/cms-sw/cmssw/pull/41736/files#diff-f9ea48cd2e3bd19ffa700c26566b06832095be6446c78486bd8612fe369b8b18R105

But ok, let merge as such (at least for the master) and I'll let you @jfernan2 decide whether it is worth to rename it or not

perrotta · 2023-05-24T12:34:08Z

+1

Introduced Online mode for DQMStore

f4be4f2

cmsbuild added this to the CMSSW_13_2_X milestone May 19, 2023

cmsbuild added dqm-pending pending-signatures tests-pending orp-pending code-checks-pending labels May 19, 2023

cmsbuild added code-checks-rejected and removed code-checks-pending labels May 19, 2023

Code cheks and format

e2e4b22

cmsbuild added code-checks-pending and removed code-checks-rejected labels May 21, 2023

cmsbuild added code-checks-rejected and removed code-checks-pending labels May 21, 2023

Code checks

30c805e

cmsbuild added code-checks-pending and removed code-checks-rejected labels May 21, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels May 21, 2023

jfernan2 changed the title ~~[DRAFT] Online mode for DQMStore~~ DQM: Online mode for DQMStore May 22, 2023

jfernan2 mentioned this pull request May 23, 2023

[13_1_X] DQM: Online mode for DQMStore #41750

Merged

cmsbuild added tests-started and removed tests-pending labels May 23, 2023

This was referenced May 23, 2023

[13_0_X] DQM: Online mode for DQMStore #41751

Closed

[13_0_X] DQM: Online mode for DQMStore #41752

Merged

cmsbuild added tests-approved and removed tests-started labels May 23, 2023

cmsbuild added the urgent label May 23, 2023

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels May 24, 2023

perrotta reviewed May 24, 2023

View reviewed changes

cmsbuild added orp-approved and removed orp-pending labels May 24, 2023

cmsbuild merged commit 6d74dd1 into cms-sw:master May 24, 2023

cmsbuild mentioned this pull request May 27, 2023

[GCC] Update to GCC 12.3.1 cms-sw/cmsdist#8526

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DQM: Online mode for DQMStore #41736

DQM: Online mode for DQMStore #41736

jfernan2 commented May 19, 2023 •

edited

Loading

cmsbuild commented May 19, 2023

cmsbuild commented May 21, 2023

cmsbuild commented May 21, 2023

cmsbuild commented May 21, 2023

perrotta commented May 23, 2023

cmsbuild commented May 23, 2023

perrotta commented May 23, 2023

emanueleusai commented May 24, 2023

cmsbuild commented May 24, 2023

perrotta May 24, 2023 •

edited

Loading

perrotta commented May 24, 2023

DQM: Online mode for DQMStore #41736

DQM: Online mode for DQMStore #41736

Conversation

jfernan2 commented May 19, 2023 • edited Loading

PR description:

PR validation:

cmsbuild commented May 19, 2023

cmsbuild commented May 21, 2023

cmsbuild commented May 21, 2023

cmsbuild commented May 21, 2023

perrotta commented May 23, 2023

cmsbuild commented May 23, 2023

Comparison Summary

perrotta commented May 23, 2023

emanueleusai commented May 24, 2023

cmsbuild commented May 24, 2023

perrotta May 24, 2023 • edited Loading

Choose a reason for hiding this comment

perrotta commented May 24, 2023

jfernan2 commented May 19, 2023 •

edited

Loading

perrotta May 24, 2023 •

edited

Loading