-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8_0_X] Make sure to report an error if process.options.numberOfThreads has wrong type #41735
[8_0_X] Make sure to report an error if process.options.numberOfThreads has wrong type #41735
Conversation
A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_0_X. It involves the following packages:
@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-79d31c/32724/summary.html Comparison SummarySummary:
|
Differences are similar to as reported in #40708 (comment), and are unrelated to this PR |
+core |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Backport of #41349, title says it all. Contrary to the other backports, I did not include the unit tests here, because apparently 8_0_X does not support the
<test ...>
syntax for defining unit tests, and therefore making them functional would have required quite some work (that I would not want to do).PR validation:
Code compiles.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Backport of #41349