Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding RecHits plots for SiStrip stereo modules (backport to 13.0.x) #41726

Merged
merged 1 commit into from
May 23, 2023

Conversation

mascioti
Copy link
Contributor

PR description:

Adding Number of RecHits on Strip Stereo Modules on the Tracker DQM

PR validation:

runTheMatrix.py -l 12434

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #41725 in order to be used in current datataking

@cmsbuild
Copy link
Contributor

cmsbuild commented May 18, 2023

A new Pull Request was created by @mascioti for CMSSW_13_0_X.

It involves the following packages:

  • DQM/SiStripMonitorTrack (dqm)

@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@arossi83, @hdelanno, @sroychow, @fioriNTU, @jandrea, @idebruyn, @mmusich, @threus this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented May 18, 2023

@mascioti, please provide a backport for 13.1.x as well and edit the title so that ot is clear this PR is a backport to 13.0.x. Thank you.

@mascioti mascioti changed the title Adding RecHits plots for SiStrip streo modules Adding RecHits plots for SiStrip stereo modules (backport to 13.0.x) May 18, 2023
@mmusich
Copy link
Contributor

mmusich commented May 18, 2023

please test

@arossi83
Copy link
Contributor

@mascioti, please provide a backport for 13.1.x as well and edit the title so that ot is clear this PR is a backport to 13.0.x. Thank you.

#41728

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a2b414/32718/summary.html
COMMIT: 3876797
CMSSW: CMSSW_13_0_X_2023-05-18-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41726/32718/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • Reco comparison results: 298 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3316771
  • DQMHistoTests: Total failures: 4156
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3312593
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 101.38000000000002 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 1.799 KiB SiStrip/IsolatedBunches
  • DQMHistoSizes: changed ( 1000.0,... ): 1.705 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 12434.0,... ): 1.729 KiB HLT/SiStrip
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

backport of #41725

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

hold
(keep this on hold just to remind to fix the intermediate backport in 13_1_X, now broken in #41728)

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @perrotta
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@perrotta
Copy link
Contributor

unhold
(Thank you @mascioti for providing the 13_1_X backport in #41753)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3b80a3c into cms-sw:CMSSW_13_0_X May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants