Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VertexSmearing scenario for 2023 MC #41719

Merged
merged 1 commit into from
May 20, 2023

Conversation

francescobrivio
Copy link
Contributor

@francescobrivio francescobrivio commented May 18, 2023

PR description:

This PR adds the realistic VertexSmearing scenario to be used for the 2023 MC production:

  • Realistic25ns13p6TeVEarly2023Collision

Input parameters:

  • The BeamSpot is extracted from Run2023C averaging Fills 8728-8750 (thanks @dzuolo!)
  • The BPIX barycenter is taken from this twiki

IMPORTANT NOTE:
Even though at the moment this scenario is not used anywhere in the release, we need this merged asap in order to produce relvals with this smearing and fit the BeamSpot to be added to the GTs for 2023 MC.

PR validation:

Code compiles (at the moment this scenario is not used anywhere in the release)

Backport:

Not a backport. Backports available at:

FYI @mmusich @cms-sw/alca-l2

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41719/35596

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

  • Configuration/StandardSequences (operations)
  • IOMC/EventVertexGenerators (simulation)

@perrotta, @rappoccio, @civanch, @mdhildreth, @cmsbuild, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @VourMa, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @grzanka, @mmusich, @sameasy, @mtosi, @dgulhan, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor Author

urgent

  • as mentioned in the PR description we need this to generate RelVals and fit the BeamSpot to be added to the GTs

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

  • even though nothing is really testing the new scenario

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-36313d/32709/summary.html
COMMIT: 4a42533
CMSSW: CMSSW_13_2_X_2023-05-17-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41719/32709/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3222710
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3222682
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@francescobrivio
Copy link
Contributor Author

@cms-sw/simulation-l2 a kind ping to please review (and sign) this PR and its backports #41720 and #41721.

@civanch
Copy link
Contributor

civanch commented May 20, 2023

+1

@perrotta
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants