Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[131X] use qScale in charge reweighting #41708

Merged
merged 1 commit into from
May 20, 2023

Conversation

tvami
Copy link
Contributor

@tvami tvami commented May 17, 2023

PR description:

See #41623

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #41623

@tvami
Copy link
Contributor Author

tvami commented May 17, 2023

backport of #41623

@cmsbuild
Copy link
Contributor

cmsbuild commented May 17, 2023

A new Pull Request was created by @tvami (Tamas Vami) for CMSSW_13_1_X.

It involves the following packages:

  • SimTracker/Common (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@JanFSchulte, @echabert, @VourMa, @robervalwalsh, @GiacomoSguazzoni, @gbenelli, @rovere, @VinInn, @missirol, @prolay, @mtosi, @mmusich, @threus, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor Author

tvami commented May 17, 2023

test parameters:

  • workflow = 250202.184

@tvami
Copy link
Contributor Author

tvami commented May 17, 2023

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7ade23/32696/summary.html
COMMIT: 132bebc
CMSSW: CMSSW_13_1_X_2023-05-17-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41708/32696/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 36 lines to the logs
  • Reco comparison results: 13785 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3325016
  • DQMHistoTests: Total failures: 62061
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3262932
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.21999999999999997 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 250202.181 ): -0.352 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.184 ): 0.132 KiB SiStrip/MechanicalView
  • Checked 212 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

@cms-sw/simulation-l2 would you agree with having this in 13_1_0 so that it can be considered in the simulation campaigns to be opened with this release cycle? If so, please sign it.

@civanch
Copy link
Contributor

civanch commented May 20, 2023

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit efaaaba into cms-sw:CMSSW_13_1_X May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants