[13.1.X] Produce a fake BeamSpot object in BeamSpotOnlineProducer when using transient record logic and OnlineBeamSpotESProducer returned a fake

[mmusich]

backport of #41597

PR description:

While working on #41193, I have noticed that despite OnlineBeamSpotESProducer has a refined logic in order to put into the event setup a fake BeamSpot when certain conditions are not met:

cmssw/RecoVertex/BeamSpotProducer/plugins/OnlineBeamSpotESProducer.cc

Lines 168 to 174 in a52f2d1

	if (best) {
	return std::shared_ptr<const BeamSpotObjects>(best, edm::do_nothing_deleter());
	} else {
	return std::shared_ptr<const BeamSpotObjects>(&fakeBS_, edm::do_nothing_deleter());
	edm::LogInfo("OnlineBeamSpotESProducer")
	<< "None of the Online BeamSpots in the ES is suitable, \n returning a fake one. ";
	}

the current BeamSpotOnlineProducer logic, if useTransientRecord_ is true and the OnlineBeamSpotESProducer returned a fake beamspot, just falls back to DB (reading the content of BeamSpotObjectsRcd, populated by the PCL in realtime workflows) - which I have understood from the Beam Spot experts is not the right / expected behaviour.

cmssw/RecoVertex/BeamSpotProducer/plugins/BeamSpotOnlineProducer.cc

Lines 104 to 111 in a52f2d1

	if (useTransientRecord_) {
	auto const& spotDB = iSetup.getData(beamTransientToken_);
	if (spotDB.beamType() != 2) {
	if (shoutMODE && beamTransientRcdESWatcher_.check(iSetup)) {
	edm::LogWarning("BeamSpotFromDB")
	<< "Online Beam Spot producer falls back to DB value because the ESProducer returned a fake beamspot ";
	}
	fallBackToDB = true;

In this PR (in commit cc1512b) I change the current behaviour, such that instead now it will indeed produce a fake BS for consumption online (as it was originally devised).
This has a consequence, that in the case in which we want indeed to fall-back to DB (e.g. for the Phase-2 HLT testing case, after #41193), the change will alter physics in an undesired way. For this reason, it has been necessary to supply to the auto:phase2_realistic GlobalTag key the right BeamSpotOnline*ObjectsRcd payloads in order for the OnlineBeamSpotESProducer to not pick up a fake BeamSpot. This is done in commit 579d59f , while commit d36e056 sets the the time threshold to 1e6 seconds (as it's done for the Run-3 menus, see https://github.com/cms-sw/cmssw/pull/41193/files#r1152358315) to the same effect.
The difference in Global Tags is:

• https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/131X_mcRun4_realistic_v4/131X_mcRun4_realistic_v5

To supply such payloads, I have found convenient to create a new plugin BeamSpotOnlineFromOfflineConverter that taking a BeamSpotObject in input creates an sqlite file in output containing a payload of the type BeamSpotOnlineObjects. This has been added in commit 9aeabd1, while commits f933305 and 84271d4 add a utility accessor to the BeamSpotOnlineObjects condtion format to be able to readily copy from a BeamSpotObjects payload (friend class) all the common parameters. Finally commit 8848ad8 adds this converter to the battery of unit tests of the CondTools/BeamSpot package.

PR validation:

cmssw complies. Passes back unit tests.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a verbatim backport of #41597, to be backported down to 13.0.X for 2023 data-taking purposes

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_1_X.

It involves the following packages:

• CondFormats/BeamSpotObjects (db, alca)
• CondTools/BeamSpot (db, alca)
• Configuration/AlCa (alca)
• HLTrigger/Configuration (hlt)
• RecoVertex/BeamSpotProducer (reconstruction, alca)

@Martin-Grunewald, @clacaputo, @cmsbuild, @missirol, @saumyaphor4252, @tvami, @mandrenguyen, @francescobrivio can you please review it and eventually sign? Thanks.
@beaucero, @fabiocos, @VourMa, @silviodonato, @SohamBhattacharya, @GiacomoSguazzoni, @JanFSchulte, @tocheng, @VinInn, @Martin-Grunewald, @missirol, @rovere, @mmusich, @mtosi, @dgulhan, @seemasharmafnal, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Produce a fake BeamSpot object in BeamSpotOnlineProducer when using transient record logic and OnlineBeamSpotESProducer returned a fake #41597

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-679b29/32631/summary.html
COMMIT: 579d59f
CMSSW: CMSSW_13_1_X_2023-05-14-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41673/32631/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 13 lines from the logs
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3461906
• DQMHistoTests: Total failures: 31
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3461853
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[tvami]

+1

• diffs observed are expected

[missirol]

+hlt

[clacaputo]

+reconstruction

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1