Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend x-axis range of "vs-lumi" harvesting outputs in HLT online-DQM #41665

Merged
merged 1 commit into from
May 15, 2023

Conversation

missirol
Copy link
Contributor

PR description:

This PR adjusts the x-axis upper limit of the "vs-lumi" harvesting outputs produced by one HLT client of the online DQM (i.e. hlt_dqm_clientPB-live). The relevant quantity is the instantaneous luminosity, and the upper limit is changed from 2e34 Hz/cm^2 to 3e34 Hz/cm^2. More details can be found in CMSHLT-2803.

PR validation:

Manual checks, e.g.

#!/bin/bash -ex

INPUTFILE=file:/eos/cms/store/group/dpg_trigger/comm_trigger/TriggerStudiesGroup/STORM/RAW/Run2022G_EphemeralHLTPhysics0_run362616/82ed6819-9c96-49e1-a5ed-b5edc1a90108.root

RUNNUM=362616

rm -rf run"${RUNNUM}"* upload
convertToRaw -f 500 -l 500 -r "${RUNNUM}":209 -o . -- "${INPUTFILE}"

tmpfile=$(mktemp)
hltConfigFromDB --runNumber 367406 > "${tmpfile}"
cat <<@EOF >> "${tmpfile}"
process.load("run${RUNNUM}_cff")
process.hltLumiMonitor.histoPSet.lumiPSet.xmax = 30000
process.hltLumiMonitor.histoPSet.lumiPSet.nbins = 6000
process.hltOnlineBeamSpotESProducer.timeThreshold = int(1e6)
del process.PrescaleService
removeObjs = [pathName for pathName in process.paths_() if not pathName.endswith('Path')] + [pathName for pathName in process.finalpaths_()]
for foo in removeObjs:
    process.__delattr__(foo)
@EOF
edmConfigDump "${tmpfile}" > hlt.py

cmsRun hlt.py &> hlt.log

cmsRun "${CMSSW_BASE}"/src/DQM/Integration/python/clients/hlt_dqm_clientPB-live_cfg.py \
  runInputDir=. runNumber="${RUNNUM}" runkey=pp_run scanOnce=True \
  datafnPosition=4

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

CMSSW_13_0_X
CMSSW_13_1_X

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41665/35540

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

  • DQM/Integration (dqm)

@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@battibass, @threus, @batinkov, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bc820d/32613/summary.html
COMMIT: 726c75d
CMSSW: CMSSW_13_2_X_2023-05-14-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41665/32613/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 8 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3461906
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3461875
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@missirol missirol deleted the fix_hltOnlineDQMLumiRanges branch June 15, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants