[13_0_x] PPS Pixel DQM: assign errors to right plots

[fabferro]

PR description:

This PR is a bug fix in filling the plots in PPS Pixel DQM. Using the DAQ map, errors coming from pixels are assigned to the right detector plane instead of being put in a unidentified-detector plot, unless strictly necessary.

PR validation:

With matrix wfs 138.4 (run3) and 136.874 (run2) and with brand new 2023 data. Errors are now put inside the right plots.

This fix is needed for the data taking asap.

This is a backport of PR #41649

[cmsbuild]

A new Pull Request was created by @fabferro (Fabrizio Ferro) for CMSSW_13_0_X.

It involves the following packages:

• DQM/CTPPS (dqm)

@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@grzanka this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from PPS Pixel DQM: assign errors to right plots #41649

[perrotta]

backport of #41649

[emanueleusai]

type ctpps

[emanueleusai]

please test

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-37ee52/32620/summary.html
COMMIT: 7088679
CMSSW: CMSSW_13_0_X_2023-05-14-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41651/32620/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 1306.0

----- Begin Fatal Exception 15-May-2023 04:20:11 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'dqmoffline_step'
   [2] Calling method for module CTPPSPixelDQMSource/'ctppsPixelDQMOfflineSource'
Exception Message:
No "CTPPSPixelDAQMappingRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

• 1330.0

----- Begin Fatal Exception 15-May-2023 04:20:49 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'dqmoffline_step'
   [2] Calling method for module CTPPSPixelDQMSource/'ctppsPixelDQMOfflineSource'
Exception Message:
No "CTPPSPixelDAQMappingRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

• 25202.0

----- Begin Fatal Exception 15-May-2023 04:28:06 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'dqmoffline_step'
   [2] Calling method for module CTPPSPixelDQMSource/'ctppsPixelDQMOfflineSource'
Exception Message:
No "CTPPSPixelDAQMappingRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

[syuvivida]

@fabferro @francescobrivio
Just to add more information, we tested this PR at p5 machines with the 13_0_X Global tag: 130X_dataRun3_HLT_v2 and jobs were running fine without crashes at the playback. You could also take a look at the playback DQMGUI here

[francescobrivio]

@fabferro @francescobrivio Just to add more information, we tested this PR at p5 machines with the 13_0_X Global tag: 130X_dataRun3_HLT_v2 and jobs were running fine without crashes at the playback. You could also take a look at the playback DQMGUI here

Yes because all the new GTs (> 2018) have the correct records.
Here the failing workflows are MC ones from Run2.

[francescobrivio]

Btw the discussion is actually ongoing in the master PR #41649

[cmsbuild]

Pull request #41651 was updated. @nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please check and sign again.

[emanueleusai]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-37ee52/32679/summary.html
COMMIT: d077d9a
CMSSW: CMSSW_13_0_X_2023-05-16-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41651/32679/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• Reco comparison results: 13 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3316072
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3316041
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -92481.324 KiB( 48 files compared)
• DQMHistoSizes: changed ( 1306.0,... ): -16565.990 KiB CTPPS/TimingDiamond
• DQMHistoSizes: changed ( 1306.0,... ): -11346.722 KiB CTPPS/TrackingPixel
• DQMHistoSizes: changed ( 1306.0,... ): -2360.820 KiB CTPPS/DiamondSampic
• DQMHistoSizes: changed ( 1306.0,... ): -553.576 KiB CTPPS/common
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1