Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_1_x] PPS Pixel DQM: assign errors to right plots #41650

Merged
merged 3 commits into from
May 20, 2023
Merged

[13_1_x] PPS Pixel DQM: assign errors to right plots #41650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf1d4b0
Assign errors to right plots
fabferro May 12, 2023
1e85fb0
fixes for 2016 data and mc
fabferro May 16, 2023
b488d2a
fixes
fabferro May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
117 changes: 101 additions & 16 deletions DQM/CTPPS/plugins/CTPPSPixelDQMSource.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@
#include "DataFormats/CTPPSReco/interface/CTPPSPixelLocalTrack.h"
#include "DataFormats/Common/interface/TriggerResults.h"

#include "CondFormats/DataRecord/interface/CTPPSPixelDAQMappingRcd.h"
#include "CondFormats/PPSObjects/interface/CTPPSPixelDAQMapping.h"

#include <string>

//-----------------------------------------------------------------------------
Expand All @@ -49,7 +52,9 @@ class CTPPSPixelDQMSource : public DQMEDAnalyzer {
edm::EDGetTokenT<edm::DetSetVector<CTPPSPixelCluster>> tokenCluster;
edm::EDGetTokenT<edm::DetSetVector<CTPPSPixelLocalTrack>> tokenTrack;
edm::EDGetTokenT<edm::TriggerResults> tokenTrigResults;
edm::ESGetToken<CTPPSPixelDAQMapping, CTPPSPixelDAQMappingRcd> tokenPixelDAQMapping;
std::string randomHLTPath;
std::string mappingLabel;

static constexpr int NArms = 2;
static constexpr int NStationMAX = 3; // in an arm
Expand Down Expand Up @@ -218,6 +223,8 @@ CTPPSPixelDQMSource::CTPPSPixelDQMSource(const edm::ParameterSet &ps)
tokenCluster = consumes<DetSetVector<CTPPSPixelCluster>>(ps.getUntrackedParameter<edm::InputTag>("tagRPixCluster"));
tokenTrack = consumes<DetSetVector<CTPPSPixelLocalTrack>>(ps.getUntrackedParameter<edm::InputTag>("tagRPixLTrack"));
tokenTrigResults = consumes<edm::TriggerResults>(ps.getUntrackedParameter<edm::InputTag>("tagTrigResults"));
tokenPixelDAQMapping = esConsumes<CTPPSPixelDAQMapping, CTPPSPixelDAQMappingRcd>();
mappingLabel = ps.getUntrackedParameter<std::string>("mappingLabel");
offlinePlots = ps.getUntrackedParameter<bool>("offlinePlots", true);
onlinePlots = ps.getUntrackedParameter<bool>("onlinePlots", true);

Expand Down Expand Up @@ -524,7 +531,7 @@ void CTPPSPixelDQMSource::bookHistograms(DQMStore::IBooker &ibooker, edm::Run co
0.,
double(NplaneMAX * NROCsMAX),
0.,
rpixValues::ROCSizeInX *rpixValues::ROCSizeInY,
rpixValues::ROCSizeInX * rpixValues::ROCSizeInY,
"");
hp2HitsMultROC_LS[indexP]->getTProfile2D()->SetOption("colz");
hp2HitsMultROC_LS[indexP]->getTProfile2D()->SetMinimum(1.0e-10);
Expand Down Expand Up @@ -689,6 +696,8 @@ void CTPPSPixelDQMSource::analyze(edm::Event const &event, edm::EventSetup const
Handle<edm::TriggerResults> hltResults;
event.getByToken(tokenTrigResults, hltResults);

const CTPPSPixelDAQMapping *mapping = &eventSetup.getData(tokenPixelDAQMapping);

if (onlinePlots) {
hBX->Fill(event.bunchCrossing());
hBXshort->Fill(event.bunchCrossing());
Expand Down Expand Up @@ -849,13 +858,13 @@ void CTPPSPixelDQMSource::analyze(edm::Event const &event, edm::EventSetup const
} // if(pixDigi.isValid()) {

if (pixError.isValid()) {
std::map<CTPPSPixelFramePosition, CTPPSPixelROCInfo> rocMapping = mapping->ROCMapping;
for (const auto &ds_error : *pixError) {
int idet = getDet(ds_error.id);
if (idet != DetId::VeryForward) {
if (idet == 15) { //dummy det id: store in a plot with fed info

for (DetSet<CTPPSPixelDataError>::const_iterator dit = ds_error.begin(); dit != ds_error.end(); ++dit) {
h2ErrorCodeUnidDet->Fill(dit->errorType(), dit->fedId());
// recover fed channel number
int chanNmbr = -1;
if (dit->errorType() == 32 || dit->errorType() == 33 || dit->errorType() == 34) {
Expand All @@ -865,6 +874,30 @@ void CTPPSPixelDQMSource::analyze(edm::Event const &event, edm::EventSetup const
uint32_t errorWord = dit->errorWord32();
chanNmbr = (errorWord >> LINK_shift) & LINK_mask;
}

// recover detector Id from chanNmbr and fedId
CTPPSPixelFramePosition fPos(dit->fedId(), 0, chanNmbr, 0); // frame position for ROC 0
std::map<CTPPSPixelFramePosition, CTPPSPixelROCInfo>::const_iterator mit;
int index = -1;
int plane = -1;
bool goodRecovery = false;
mit = rocMapping.find(fPos);
if (mit != rocMapping.end()) {
CTPPSPixelROCInfo rocInfo = (*mit).second;
CTPPSPixelDetId recoveredDetId(rocInfo.iD);
plane = recoveredDetId.plane();
index = getRPindex(recoveredDetId.arm(), recoveredDetId.station(), recoveredDetId.rp());
if (RPindexValid[index] && !isPlanePlotsTurnedOff[recoveredDetId.arm()][recoveredDetId.station()]
[recoveredDetId.rp()][recoveredDetId.plane()])
goodRecovery = true;
} // if (mit != rocMapping.end())

if (goodRecovery) {
h2ErrorCodeRP[index]->Fill(dit->errorType(), plane);
} else {
h2ErrorCodeUnidDet->Fill(dit->errorType(), dit->fedId());
}

bool fillFED = false;
int iFed = dit->fedId() - minFedNumber;
if (iFed >= 0 && iFed < numberOfFeds)
Expand Down Expand Up @@ -920,42 +953,74 @@ void CTPPSPixelDQMSource::analyze(edm::Event const &event, edm::EventSetup const
int t6 = (errorWord >> DB6_shift) & DataBit_mask;
int t7 = (errorWord >> DB7_shift) & DataBit_mask;
if (t0 == 1) {
h2TBMMessageUnidDet->Fill(0, dit->fedId());
if (goodRecovery) {
h2TBMMessageRP[index]->Fill(0, plane);
} else {
h2TBMMessageUnidDet->Fill(0, dit->fedId());
}
if (fillFED)
h2TBMMessageFED[iFed]->Fill(0, chanNmbr);
}
if (t1 == 1) {
h2TBMMessageUnidDet->Fill(1, dit->fedId());
if (goodRecovery) {
h2TBMMessageRP[index]->Fill(1, plane);
} else {
h2TBMMessageUnidDet->Fill(1, dit->fedId());
}
if (fillFED)
h2TBMMessageFED[iFed]->Fill(1, chanNmbr);
}
if (t2 == 1) {
h2TBMMessageUnidDet->Fill(2, dit->fedId());
if (goodRecovery) {
h2TBMMessageRP[index]->Fill(2, plane);
} else {
h2TBMMessageUnidDet->Fill(2, dit->fedId());
}
if (fillFED)
h2TBMMessageFED[iFed]->Fill(2, chanNmbr);
}
if (t3 == 1) {
h2TBMMessageUnidDet->Fill(3, dit->fedId());
if (goodRecovery) {
h2TBMMessageRP[index]->Fill(3, plane);
} else {
h2TBMMessageUnidDet->Fill(3, dit->fedId());
}
if (fillFED)
h2TBMMessageFED[iFed]->Fill(3, chanNmbr);
}
if (t4 == 1) {
h2TBMMessageUnidDet->Fill(4, dit->fedId());
if (goodRecovery) {
h2TBMMessageRP[index]->Fill(4, plane);
} else {
h2TBMMessageUnidDet->Fill(4, dit->fedId());
}
if (fillFED)
h2TBMMessageFED[iFed]->Fill(4, chanNmbr);
}
if (t5 == 1) {
h2TBMMessageUnidDet->Fill(5, dit->fedId());
if (goodRecovery) {
h2TBMMessageRP[index]->Fill(5, plane);
} else {
h2TBMMessageUnidDet->Fill(5, dit->fedId());
}
if (fillFED)
h2TBMMessageFED[iFed]->Fill(5, chanNmbr);
}
if (t6 == 1) {
h2TBMMessageUnidDet->Fill(6, dit->fedId());
if (goodRecovery) {
h2TBMMessageRP[index]->Fill(6, plane);
} else {
h2TBMMessageUnidDet->Fill(6, dit->fedId());
}
if (fillFED)
h2TBMMessageFED[iFed]->Fill(6, chanNmbr);
}
if (t7 == 1) {
h2TBMMessageUnidDet->Fill(7, dit->fedId());
if (goodRecovery) {
h2TBMMessageRP[index]->Fill(7, plane);
} else {
h2TBMMessageUnidDet->Fill(7, dit->fedId());
}
if (fillFED)
h2TBMMessageFED[iFed]->Fill(7, chanNmbr);
}
Expand All @@ -964,27 +1029,47 @@ void CTPPSPixelDQMSource::analyze(edm::Event const &event, edm::EventSetup const
uint32_t stateMach_mask = ~(~uint32_t(0) << stateMach_bits);
uint32_t stateMach = (errorWord >> stateMach_shift) & stateMach_mask;
if (stateMach == 0) {
h2TBMTypeUnidDet->Fill(0, dit->fedId());
if (goodRecovery) {
h2TBMTypeRP[index]->Fill(0, plane);
} else {
h2TBMTypeUnidDet->Fill(0, dit->fedId());
}
if (fillFED)
h2TBMTypeFED[iFed]->Fill(0, chanNmbr);
} else {
if (((stateMach >> DB0_shift) & DataBit_mask) == 1) {
h2TBMTypeUnidDet->Fill(1, dit->fedId());
if (goodRecovery) {
h2TBMTypeRP[index]->Fill(1, plane);
} else {
h2TBMTypeUnidDet->Fill(1, dit->fedId());
}
if (fillFED)
h2TBMTypeFED[iFed]->Fill(1, chanNmbr);
}
if (((stateMach >> DB1_shift) & DataBit_mask) == 1) {
h2TBMTypeUnidDet->Fill(2, dit->fedId());
if (goodRecovery) {
h2TBMTypeRP[index]->Fill(2, plane);
} else {
h2TBMTypeUnidDet->Fill(2, dit->fedId());
}
if (fillFED)
h2TBMTypeFED[iFed]->Fill(2, chanNmbr);
}
if (((stateMach >> DB2_shift) & DataBit_mask) == 1) {
h2TBMTypeUnidDet->Fill(3, dit->fedId());
if (goodRecovery) {
h2TBMTypeRP[index]->Fill(3, plane);
} else {
h2TBMTypeUnidDet->Fill(3, dit->fedId());
}
if (fillFED)
h2TBMTypeFED[iFed]->Fill(3, chanNmbr);
}
if (((stateMach >> DB3_shift) & DataBit_mask) == 1) {
h2TBMTypeUnidDet->Fill(4, dit->fedId());
if (goodRecovery) {
h2TBMTypeRP[index]->Fill(4, plane);
} else {
h2TBMTypeUnidDet->Fill(4, dit->fedId());
}
if (fillFED)
h2TBMTypeFED[iFed]->Fill(4, chanNmbr);
}
Expand All @@ -994,7 +1079,7 @@ void CTPPSPixelDQMSource::analyze(edm::Event const &event, edm::EventSetup const
h2ErrorCodeFED[iFed]->Fill(dit->errorType(), chanNmbr);
}
continue;
}
} // if idet == 15
if (verbosity > 1)
LogPrint("CTPPSPixelDQMSource") << "not CTPPS: ds_error.id" << ds_error.id;
continue;
Expand Down
6 changes: 6 additions & 0 deletions DQM/CTPPS/python/ctppsDQM_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,12 @@

)

from Configuration.Eras.Modifier_ctpps_2016_cff import ctpps_2016
ctpps_2016.toReplaceWith(
_ctppsDQMOfflineSource,
cms.Sequence(
)
)

# the actually used sequences must be empty for pre-PPS data
from Configuration.Eras.Modifier_ctpps_cff import ctpps
Expand Down
6 changes: 4 additions & 2 deletions DQM/CTPPS/python/ctppsPixelDQMSource_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,14 @@
tagRPixCluster = cms.untracked.InputTag("ctppsPixelClusters", ""),
tagRPixLTrack = cms.untracked.InputTag("ctppsPixelLocalTracks", ""),
tagTrigResults = cms.untracked.InputTag("TriggerResults","","HLT"),
mappingLabel = cms.untracked.string("RPix"),
RPStatusWord = cms.untracked.uint32(0x8008), # rpots in readout:220_fr_hr; 210_fr_hr
verbosity = cms.untracked.uint32(0),
randomHLTPath = cms.untracked.string("HLT_Random_v3"),
offlinePlots = cms.untracked.bool(False),
onlinePlots = cms.untracked.bool(True),
turnOffPlanePlots = cms.untracked.vstring(), # add tags for planes to be shut off,
# e.g. "0_2_3_4" for arm 0 station 2 rp 3 plane 4
# e.g. "0_2_3_4" for arm 0 station 2 rp 3 plane 4
)

ctppsPixelDQMOfflineSource = DQMEDAnalyzer('CTPPSPixelDQMSource',
Expand All @@ -23,11 +24,12 @@
tagRPixCluster = cms.untracked.InputTag("ctppsPixelClusters", ""),
tagRPixLTrack = cms.untracked.InputTag("ctppsPixelLocalTracks", ""),
tagTrigResults = cms.untracked.InputTag("TriggerResults","","HLT"),
mappingLabel = cms.untracked.string("RPix"),
RPStatusWord = cms.untracked.uint32(0x8008), # rpots in readout: 220_fr_hr; 210_fr_hr
verbosity = cms.untracked.uint32(0),
randomHLTPath = cms.untracked.string("HLT_Random_v3"),
offlinePlots = cms.untracked.bool(True),
onlinePlots = cms.untracked.bool(False),
turnOffPlanePlots = cms.untracked.vstring(), # add tags for planes to be shut off,
# e.g. "0_2_3_4" for arm 0 station 2 rp 3 plane 4
# e.g. "0_2_3_4" for arm 0 station 2 rp 3 plane 4
)