13_1 backport: Fix numeric issues in PFCand scaling, add some debug output

[kdlong]

PR description:

Fix candidate scaling in cases where momentum is a huge number, where the mass-aware scaling hits numeric issues. The fix is simple, just calculate E in a way without ratios involved. This should be a fix for #41397

PR validation:

Checked that the crash and nan candidate are removed. The mass scaling works properly now.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #41550

[cmsbuild]

A new Pull Request was created by @kdlong (Kenneth Long) for CMSSW_13_1_X.

It involves the following packages:

• DataFormats/ParticleFlowCandidate (reconstruction)
• RecoParticleFlow/PFProducer (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@mmarionncern, @rovere, @lgray, @missirol, @hatakeyamak, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Fix numeric issues in PFCand scaling, add some debug output #41550

[clacaputo]

please test

[mandrenguyen]

backport of #41550

[mandrenguyen]

type pf

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5921aa/32541/summary.html
COMMIT: f259152
CMSSW: CMSSW_13_1_X_2023-05-10-1200/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41608/32541/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 13 lines from the logs
• Reco comparison results: 24 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3460836
• DQMHistoTests: Total failures: 51
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3460763
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+1
@perrotta @rappoccio
This is a more proper fix for the ak4PFJets crash than was done in #41473.
I leave it for you to judge whether we should merge this into 13_1_X and 13_0_X, given that prompt reco is running fine now.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[kdlong]

Thanks @mandrenguyen. My feeling is that it ideally would be back ported. It's quite a corner case that this happens (really large momentum+uncertainty track matched to much smaller calo energy), but when it does happen, the proper averaging and scaling gives the sensible kinematics which is preferable to just skipping them.

[perrotta]

+1