Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed delayed jet skim to add HT350 and L1Tau paths #41592

Merged
merged 1 commit into from
May 14, 2023

Conversation

rtschmitz
Copy link

PR description:

Since the first delayed jet skim, new delayed jet paths have been added to the HLT which have different selections and a slightly different naming convention. These include the following unprescaled paths:

Prompt:
HLT_L1Tau_DelayedJet40_DoubleDelay1nsTrackless_v1
HLT_L1Tau_DelayedJet40_DoubleDelay1p25nsInclusive_v1
HLT_L1Tau_DelayedJet40_SingleDelay2p5nsTrackless_v1
HLT_L1Tau_DelayedJet40_SingleDelay3p5nsInclusive_v1
HLT_HT350_DelayedJet40_SingleDelay3nsInclusive_v1

Parking:
HLT_HT350_DelayedJet40_SingleDelay1p5To3nsInclusive_v1
HLT_HT350_DelayedJet40_SingleDelay1p6To3nsInclusive_v1 (backup)
HLT_HT350_DelayedJet40_SingleDelay1p75To3nsInclusive_v1 (backup)
HLT_HT430_DelayedJet40_SingleDelay1To1p5nsInclusive_v1
HLT_HT430_DelayedJet40_SingleDelay1p1To1p6nsInclusive_v1 (backup)
HLT_HT430_DelayedJet40_SingleDelay1p25To1p75nsInclusive_v1 (backup)
HLT_L1Tau_DelayedJet40_SingleDelay2p5To3p5nsInclusive_v1
HLT_L1Tau_DelayedJet40_SingleDelay2p6To3p5nsInclusive_v1 (backup)
HLT_L1Tau_DelayedJet40_SingleDelay2p75To3p5nsInclusive_v1 (backup)

This simple commit changes the skim from only picking up a fraction of the current delayed jet paths (HT430) to picking up all of them as intended (HT430, HT350, L1Tau).

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41592/35477

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2023

A new Pull Request was created by @rtschmitz for master.

It involves the following packages:

  • Configuration/Skimming (pdmv)

@cmsbuild, @bbilin, @sunilUIET, @kskovpen can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos, @youyingli this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@youyingli
Copy link
Contributor

@rtschmitz it seems there is no HLT_HT350_DelayedJet40* in here, could you please check again ? And if this is for 2023 data taking, could you also backport the PR to 13_1_X and 13_0_X? Thanks!

@rtschmitz
Copy link
Author

Hi @youyingli, they should be there now. The HT350 paths went live with the new HLT 2023 v1.1 which was released earlier today. I'll also backport this to 13_1_X and 13_0_X.

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-52be6e/32609/summary.html
COMMIT: acb42aa
CMSSW: CMSSW_13_2_X_2023-05-14-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41592/32609/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3461906
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3461881
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@kskovpen
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit deb2bbf into cms-sw:master May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants