Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-gex160Y Backport of #41464 to CMSSW version 13_1_X which contains a bug fix for ZDC simulation geometry #41558

Merged
merged 1 commit into from
May 21, 2023

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented May 5, 2023

PR description:

Backport of #41464 to CMSSW version 13_1_X which contains a bug fix for ZDC simulation geometry

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #41464

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2023

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for CMSSW_13_1_X.

It involves the following packages:

  • Configuration/Geometry (geometry, upgrade)
  • Geometry/CMSCommonData (geometry, upgrade)
  • Geometry/ForwardCommonData (geometry)

@civanch, @Dr15Jones, @bsunanda, @makortel, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@vargasa, @kpedro88, @Martin-Grunewald, @missirol, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

bsunanda commented May 5, 2023

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c1c38e/32423/summary.html
COMMIT: 8d7ac90
CMSSW: CMSSW_13_1_X_2023-05-05-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41558/32423/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • Reco comparison results: 13 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3460877
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3460846
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented May 5, 2023

+1

@perrotta
Copy link
Contributor

perrotta commented May 14, 2023

backport of #41464

@perrotta
Copy link
Contributor

@cms-sw/upgrade-l2 CMSSW_13_1_0 will be cut next week, and it is supposed to be used for the production of Phase2 samples: could you please have a look at this PR, and sign it if you agree with it?

@bsunanda
Copy link
Contributor Author

@srimanob Please approve this

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@srimanob
Copy link
Contributor

Thanks @perrotta
Looking on this PR, it is on Run-3 geometry only. However, we can merge it.

@perrotta
Copy link
Contributor

Looking on this PR, it is on Run-3 geometry only. However, we can merge it.

Indeed...
@bsunanda why are you backporting the fix for the Phase2 geometry in 13_0_X and not in 13_1_X? I would have rather exepected the contrary, since the Phase2 MC production is foreseen with 13_1_X

@srimanob
Copy link
Contributor

Hi @perrotta
For Phase-2, the related PR (#41480 ) is merged and appear in 13_1_0_pre4,
https://github.com/cms-sw/cmssw/releases/CMSSW_13_1_0_pre4

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ccbe252 into cms-sw:CMSSW_13_1_X May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants