Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPS DQM plots for new RPOTs 45-220-NR-HR and 56-220-NR-HR (backport of 41389) [13_1_X] #41520

Merged
merged 5 commits into from
May 11, 2023

Conversation

grzanka
Copy link
Contributor

@grzanka grzanka commented May 4, 2023

PR description:

This PR adds new plots to the DQM for two Roman Pots (previously not included in DQM).
Is it needed in the Online DQM GUI

PR validation:

Standard runTheMatrix and manual tests on new data by @smorovic

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #41389

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2023

A new Pull Request was created by @grzanka (Leszek Grzanka) for CMSSW_13_1_X.

It involves the following packages:

  • DQM/CTPPS (dqm)
  • DataFormats/OnlineMetaData (daq, reconstruction)

@micsucmed, @emanueleusai, @emeschi, @clacaputo, @cmsbuild, @syuvivida, @pmandrik, @mandrenguyen, @smorovic, @rvenditti can you please review it and eventually sign? Thanks.
@missirol, @fabferro, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@smorovic
Copy link
Contributor

smorovic commented May 4, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b5f5c7/32367/summary.html
COMMIT: b944345
CMSSW: CMSSW_13_1_X_2023-05-03-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41520/32367/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3460877
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3460851
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 797.1469999999998 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 46.891 KiB CTPPS/common
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2023

Pull request #41520 was updated. @micsucmed, @emanueleusai, @emeschi, @clacaputo, @cmsbuild, @syuvivida, @pmandrik, @mandrenguyen, @smorovic, @rvenditti can you please check and sign again.

@emanueleusai
Copy link
Member

type ctpps

@emanueleusai
Copy link
Member

backport of #41389

@emanueleusai
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b5f5c7/32486/summary.html
COMMIT: 70b5d0e
CMSSW: CMSSW_13_1_X_2023-05-08-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41520/32486/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3460877
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3460851
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 797.1469999999998 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 46.891 KiB CTPPS/common
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@smorovic
Copy link
Contributor

smorovic commented May 9, 2023

+1

@mandrenguyen
Copy link
Contributor

+1

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d1008c9 into cms-sw:CMSSW_13_1_X May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants