Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ALCA-DB] [LLVM16]Fix set but unused variables warnings #41509

Merged
merged 1 commit into from
May 3, 2023

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented May 3, 2023

CLANG IBs (which now use clang16) has a lot of warnings like [a]. This PR fixes few of these

[a]

warning: variable 'XXX' set but not used [-Wunused-but-set-variable]

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41509/35382

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2023

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

  • CondFormats/DTObjects (db, alca)
  • CondFormats/RPCObjects (db, alca)
  • CondFormats/SiStripObjects (db, alca)

@cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks.
@erikbutz, @battibass, @tocheng, @VinInn, @mmusich, @threus, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented May 3, 2023

@cmsbuild , please test for CMSSW_13_1_CLANG_X

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5b771e/32350/summary.html
COMMIT: 6915c5f
CMSSW: CMSSW_13_1_CLANG_X_2023-05-02-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41509/32350/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 8482 lines to the logs
  • Reco comparison results: 24554 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3460877
  • DQMHistoTests: Total failures: 39207
  • DQMHistoTests: Total nulls: 44
  • DQMHistoTests: Total successes: 3421604
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 2 / 46 workflows

@tvami
Copy link
Contributor

tvami commented May 3, 2023

+1

  • technical PR
  • CLANG build is happy

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented May 3, 2023

+1

@cmsbuild cmsbuild merged commit 97925d2 into cms-sw:master May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants