Backporting LHEGenericMassFilter changes to 10.6.X for Toponium Production

[AWildridge]

PR description:

This is a backport of PR 41372 (#41372). This extends the capabilities for the LHEGenericMassFilter plugin to allow to filter on specific particles and include whether they are final state particles or not and fixes a bug in the fillDescriptions method that made the filter unusable. This fixes bugs introduced in the previous backport (see PR 40373, #40373)

PR validation:

Passed:
scram build code-checks
scram build code-format

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

original PR 41372 (#41372). This is meant to be backported to 10.6.30 patch1 for ultra legacy monte carlo production samples of toponium. See the PR for toponium samples here: cms-sw/genproductions#3132 (comment) . The 10.6.30 patch1 was the release version the monte carlo contact was using.

[cmsbuild]

A new Pull Request was created by @AWildridge (AJ Wildridge) for CMSSW_10_6_X.

It involves the following packages:

• GeneratorInterface/GenFilters (generators)

@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @alberto-sanchez, @menglu21, @GurpreetSinghChahal can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Fixed bug. Missing edm::InputTag src default value in fillDescriptions #41372

[cmsbuild]

Pull request #41493 was updated. @SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @alberto-sanchez, @menglu21, @GurpreetSinghChahal can you please check and sign again.

[menglu21]

@cmsbuild please test

[perrotta]

backport of #41372

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-264483/32328/summary.html
COMMIT: 49c2035
CMSSW: CMSSW_10_6_X_2023-04-30-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41493/32328/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 3215686
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3215351
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 143 log files, 102 edm output root files, 35 DQM output files
• TriggerResults: no differences found

[Saptaparna]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1