Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PF candidates with nan for energy [13_0_X] #41474

Merged
merged 2 commits into from
May 1, 2023

Conversation

mandrenguyen
Copy link
Contributor

backport of #41473

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2023

A new Pull Request was created by @mandrenguyen (Matthew Nguyen) for CMSSW_13_0_X.

It involves the following packages:

  • RecoParticleFlow/PFProducer (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@missirol, @mmarionncern, @lgray, @seemasharmafnal, @hatakeyamak this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mandrenguyen
Copy link
Contributor Author

please test

@perrotta
Copy link
Contributor

perrotta commented May 1, 2023

urgent

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-783bb0/32267/summary.html
COMMIT: 2fa5275
CMSSW: CMSSW_13_0_X_2023-04-30-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41474/32267/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 14 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3554572
  • DQMHistoTests: Total failures: 113
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3554437
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor Author

type pf

@mandrenguyen
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented May 1, 2023

+1

  • The fix is simple enough, and I don't expect issues from the tests in the master IB
  • Since this has been approved by Reco, let also merge in 13_0_X and start building a patch release which includes the fix right after

@cmsbuild cmsbuild merged commit 64a18ef into cms-sw:CMSSW_13_0_X May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants