GetterOfProducts for output modules, use in DQMRootOutputModule

[wddgit]

PR description:

Extends support for GetterOfProducts to output modules and uses that instead of consumesMany in DQMRootOutputModule. DQMRootOutputModule is the last module using consumesMany in CMSSW outside of Core unit tests and finishing the consumesMany migration was the initial motivation for this work. Even without that motivation, it is a good thing that output modules now support GetterOfProducts in the same way as producers, filter and analyzers.

PR validation:

This includes a new unit test using GetterOfProducts to read products in a one, a limited and a global output module.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41460/35322

• This PR adds an extra 52KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41460/35322/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41460/35322/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41460/35323

• This PR adds an extra 52KB to repository

[cmsbuild]

A new Pull Request was created by @wddgit (W. David Dagenhart) for master.

It involves the following packages:

• DQMServices/FwkIO (dqm)
• FWCore/Framework (core)
• FWCore/Integration (core)

@smuzaffar, @Dr15Jones, @makortel, @emanueleusai, @cmsbuild, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@makortel, @missirol, @barvic this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[wddgit]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-efaba3/32239/summary.html
COMMIT: e0f085d
CMSSW: CMSSW_13_1_X_2023-04-28-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41460/32239/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 8 lines to the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3460877
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3460851
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[makortel]

Just to note, there seems to be room for abstraction to avoid copy-paste (not necessarily to be done in this PR, but I also don't mind if you do).

[wddgit]

I made it a template function. Seems better. Thanks.

[cmsbuild]

Pull request #41460 was updated. @smuzaffar, @Dr15Jones, @makortel, @emanueleusai, @cmsbuild, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

[wddgit]

please test

This includes the constexpr improvement.

I am not sure why several relVals failed in the last round of tests. It is not obvious to me from the log. I am just rerunning the tests. Maybe it is a transient issue unrelated to the PR?

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-efaba3/32279/summary.html
COMMIT: 37713ba
CMSSW: CMSSW_13_1_X_2023-05-01-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41460/32279/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 9 lines from the logs
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3460877
• DQMHistoTests: Total failures: 10
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3460845
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[emanueleusai]

There is one nontrivial DQM plot difference here (e.g. not coming from MessageLogger):
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_13_1_X_2023-05-01-1100+efaba3/56771/12434.0_TTbar_14TeV+2023/HLT_SiStrip_ControlView.html

But I cannot see how that would come from this PR, so I'm gonna go ahead and assume this is spurious.

[emanueleusai]

+1

[makortel]

There is one nontrivial DQM plot difference here (e.g. not coming from MessageLogger): https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_13_1_X_2023-05-01-1100+efaba3/56771/12434.0_TTbar_14TeV+2023/HLT_SiStrip_ControlView.html

But I cannot see how that would come from this PR, so I'm gonna go ahead and assume this is spurious.

Seems like another occurrence of #41200

[makortel]

+core

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1