L1T: read pt compression bit depth from LUT for JEC

[bundocka]

L1 will soon use finer granularity in the pt compression LUT used to obtain the JEC scale factors.
This PR removes the hard-coded pt compression data bit depth of 4 and replaces it with the bit depth obtained from the input LUT, to get the address for the JEC LUT in the jet emulator.
This change should be transparent and produce no changes to the L1 jets. This has been checked by re-emulating 2022 data.

Ran scram build code-format
Passes runTheMatrix.py -l limited -i all --ibeos
(all except 11634.911_TTbar_14TeV+2021_DD4hep Step2-FAILED)

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41452/35314

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @bundocka for master.

It involves the following packages:

• L1Trigger/L1TCalorimeter (l1)

@epalencia, @cmsbuild, @cecilecaillol, @aloeliger can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[aloeliger]

please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b53185/32219/summary.html
COMMIT: faba138
CMSSW: CMSSW_13_1_X_2023-04-27-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41452/32219/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 138.4138.4_PromptCollisions2021/step2_PromptCollisions2021.log
• 140.56140.56_RunHI2018/step2_RunHI2018.log
• 1002.41002.4_RunDoubleMuon2022B/step2_RunDoubleMuon2022B.log

Expand to see more relval errors ...

• 11634.505
• 11834.13
• 20896.0

Comparison Summary

Summary:

• You potentially added 6 lines to the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3460877
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3460846
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[aloeliger]

I have to say I'm not sure I understand the failures here. All of the JobReport xmls show unexpected job termination, but not much else, and the step2 output logs don't seem to have any consistent errors or crashes.

Is it possible this is correlated with the ongoing CERN internet issues?

[perrotta]

@aloeliger please don't care about those RelVal-Input errors.
If you agree with this PR just signi it for L1, and we'll merge it

[aloeliger]

+l1

• Bitwise logic makes sense to me. It moves the eta bits left by # of bits in pt, then "or"s in the pt bits. Should be resilient to pt bin sizing and remove unexplained hardcoded shifts.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[perrotta]

merge

• Errors in RelVal input tests are unrelated