Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ECAL Presample RMS threshold [13_0_X] #41439

Merged
merged 1 commit into from
Apr 29, 2023

Conversation

abhih1
Copy link
Contributor

@abhih1 abhih1 commented Apr 27, 2023

PR description:

This PR changes the RMS threshold in ECAL Presample quality and removes the many red spots in the plot.

PR validation:

PR validated by running the Ecal dqm client and the plot looks as expected.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a backport of the Master PR: #41438

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 27, 2023

A new Pull Request was created by @abhih1 (Abhirami Harilal) for CMSSW_13_0_X.

It involves the following packages:

  • DQM/EcalMonitorClient (dqm)

@emanueleusai, @cmsbuild, @syuvivida, @rvenditti, @micsucmed, @pmandrik can you please review it and eventually sign? Thanks.
@rchatter, @argiro, @thomreis, @wang0jin this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

backport of #41438

@syuvivida
Copy link
Contributor

syuvivida commented Apr 27, 2023

Tested at p5 with run 366533 and compared with the default release without this PR, the ECAL summary plots in the DQMGUI do seem less noisier.

@syuvivida
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8f1965/32225/summary.html
COMMIT: 9fc6456
CMSSW: CMSSW_13_0_X_2023-04-28-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41439/32225/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 1002.41002.4_RunDoubleMuon2022B/step2_RunDoubleMuon2022B.log
  • 11834.011834.0_TTbar_14TeV+2021PU/step2_TTbar_14TeV+2021PU.log
  • 20834.020834.0_TTbar_14TeV+2026D88/step2_TTbar_14TeV+2026D88.log
Expand to see more relval errors ...

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3554572
  • DQMHistoTests: Total failures: 629
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3553921
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit c1ea07b into cms-sw:CMSSW_13_0_X Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants