Run3-gex160 Modify the correct combination of ZDC xml files in Phase2 scenarios which are useful for dd4hep version

[bsunanda]

PR description:

Modify the correct combination of ZDC xml files in Phase2 scenarios which are useful for dd4hep version

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41412/35280

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• Configuration/Geometry (geometry, upgrade)
• Geometry/CMSCommonData (geometry, upgrade)

@civanch, @Dr15Jones, @bsunanda, @makortel, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@vargasa, @kpedro88, @Martin-Grunewald, @missirol, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[civanch]

@bsunanda , does this PR fix overlaps in ZDC?

[bsunanda]

No - it just corrects the use of units, removal of duplicate materials and use of correct region names. I have to work on the overlap now. So it has no effect on DDD version - only for DD4hep version.

…

________________________________ From: Vladimir Ivantchenko ***@***.***> Sent: 26 April 2023 21:28 To: cms-sw/cmssw ***@***.***> Cc: Sunanda Banerjee ***@***.***>; Mention ***@***.***> Subject: Re: [cms-sw/cmssw] Run3-gex160 Modify the correct combination of ZDC xml files in Phase2 scenarios which are useful for dd4hep version (PR #41412) @bsunanda<https://github.com/bsunanda> , does this PR fix overlaps in ZDC? — Reply to this email directly, view it on GitHub<#41412 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZOXITAB2E67YAR5D33TXDFAZLANCNFSM6AAAAAAXMO6Q4I>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a176fb/32156/summary.html
COMMIT: 639cf2d
CMSSW: CMSSW_13_1_X_2023-04-26-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41412/32156/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 4.64.6_MinimumBias2010A/step2_MinimumBias2010A.log
• 136.9136.9_RunDoubleMuon2016C/step2_RunDoubleMuon2016C.log
• 138.4138.4_PromptCollisions2021/step2_PromptCollisions2021.log

Expand to see more relval errors ...

• 140.027
• 140.026
• 140.031
• 140.047
• 140.051
• 140.068
• 140.107
• 140.114
• 140.54
• 140.56
• 140.57
• 144.6
• 11024.2
• 25200.0
• 25202.2
• 1001.2
• 1002.4
• 1002.3
• 1040.0
• 10824.505
• 10824.8
• 11024.15
• 11834.0
• 11834.13
• 11846.0
• 11846.19
• 20834.0
• 20834.501
• 20834.502
• 20896.0
• 20834.9
• 21034.114
• 21034.21
• 21034.99
• 21034.9921
• 21034.999
• 23634.103
• 23634.5
• 23696.0
• 23834.99

Comparison Summary

Summary:

• You potentially removed 17 lines from the logs
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3460685
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3460660
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a176fb/32177/summary.html
COMMIT: 639cf2d
CMSSW: CMSSW_13_1_X_2023-04-26-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41412/32177/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 3 lines from the logs
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3460685
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3460657
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[bsunanda]

@srimanob Please approve this

[srimanob]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1