Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0.X] Misceallaneous Tracker Alignment validation updates for 2023 data-taking #41408

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Apr 26, 2023

PR description:

This is a combined backport of #41378 and #41393
I add a generic vertex analyzer to be used for the Tracker Alignment alcareco monitoring. I profit of this PR to add some more histograms concerning the Beam Spot monitoring to an existing analyzer and to improve the unit test suite.
In addition it fixes some miscellaneous problems in the Tracker alignment di-muon validation code:

  • do not use range-based loops to create the candidate, which duplicated the entries in the histograms;
  • fix the pseudo-rapidity range for creating the input histograms
  • fix the inclusion of the auto-generated cfi file in the validation configuration file

PR validation:

Private tests, plus run successfully the augmented unit tests.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a combined backport of #41378 and #41393 meant for analysis of the 2023 data from the Tracker Alignment group.

@mmusich
Copy link
Contributor Author

mmusich commented Apr 26, 2023

backport of #41378

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 26, 2023

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_0_X.

It involves the following packages:

  • Alignment/OfflineValidation (alca)

@cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Apr 26, 2023

backport of #41393

@mmusich
Copy link
Contributor Author

mmusich commented Apr 26, 2023

type bug-fix

@mmusich
Copy link
Contributor Author

mmusich commented Apr 26, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9797d5/32151/summary.html
COMMIT: 0532b02
CMSSW: CMSSW_13_0_X_2023-04-25-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41408/32151/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 19 lines to the logs
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3554298
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3554269
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Apr 26, 2023

@mmusich can you please include [130X] in the PR title?

@tvami
Copy link
Contributor

tvami commented Apr 26, 2023

+alca

  • tests pass, backport-ok

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mmusich mmusich changed the title Misceallaneous Tracker Alignment validation updates for 2023 data-taking [13.0.X] Misceallaneous Tracker Alignment validation updates for 2023 data-taking Apr 26, 2023
@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 435012d into cms-sw:CMSSW_13_0_X Apr 26, 2023
@mmusich mmusich deleted the 13_0_X_dev_tk-al_fix-dimuonvalidation branch April 26, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants