[13_0_X] Update GlobalAlgBlkUnpacker to throw error in the case of headers received in the wrong order

[aloeliger]

PR description:

This is the backport of #41401

This PR has been opened in response to L1 JIRA ticket 411. HLT has noticed problems regarding the L1TRawToDigi process, which has been tracked to an issue in the GlobalAlgBlk unpacker receiving blocks and header IDs out of order. This causes a bad access/->at call,of a following BXVector, which fails somewhat un-informatively. This PR has been opened to produce a more informative failure message in case the initial header ID assumption fails.

@dinyar @kbunkow @missirol @alintulu I figured you would like to be kept in the loop on this.

PR validation:

All code compiles, has had code-formatting applied, and passes code checks. When testing on error events from the open JIRA ticket, the cms::exception reports instead of bad vector access errors.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is a backport of #41401. This PR has been backported to eventually help HLT identify this error in datataking at P5 and identify if this is the only error observed right now in 2023 data-taking for the uGT unpacker. This backport is intended for CMSSW_13_0/2023 data-taking releases.

[cmsbuild]

A new Pull Request was created by @aloeliger (Andrew Loeliger) for CMSSW_13_0_X.

It involves the following packages:

• EventFilter/L1TRawToDigi (l1)

@epalencia, @cmsbuild, @cecilecaillol, @aloeliger can you please review it and eventually sign? Thanks.
@dinyar, @missirol, @Martin-Grunewald, @thomreis, @eyigitba this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Update GlobalAlgBlkUnpacker to throw error in the case of headers received in the wrong order #41401

[aloeliger]

backport of #41401

[aloeliger]

please test

[aloeliger]

please abort

[cmsbuild]

Pull request #41402 was updated. @epalencia, @cmsbuild, @cecilecaillol, @aloeliger can you please check and sign again.

[aloeliger]

please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-50c050/32130/summary.html
COMMIT: 8e4a0c7
CMSSW: CMSSW_13_0_X_2023-04-25-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41402/32130/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 50207.050207.0_NuGun_UP15/step2_NuGun_UP15.log
• 50208.050208.0_SMS-T1tttt_mGl-1500_mLSP-100_13/step2_SMS-T1tttt_mGl-1500_mLSP-100_13.log
• 10042.010042.0_ZMM_13+2017/step2_ZMM_13+2017.log

Expand to see more relval errors ...

• 11634.15
• 20834.501

Comparison Summary

Summary:

• You potentially removed 6 lines from the logs
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3554298
• DQMHistoTests: Total failures: 10
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3554266
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[aloeliger]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-50c050/32139/summary.html
COMMIT: 8e4a0c7
CMSSW: CMSSW_13_0_X_2023-04-25-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41402/32139/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 14 lines from the logs
• Reco comparison results: 13 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3554298
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3554264
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[aloeliger]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1