Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_0_X] Fixing the missing Tau plots within the L1T offline DQM #41381

Merged

Conversation

vukasinmilosevic
Copy link
Contributor

PR description:

Updating the L1T Tau offline DQM modules to take into account changes in inputs that were causing the plots to be empty:

  • This setup was facing the same issue as previously reported for the L1T Muon offline DQM - some HLT modules are listed behind hltBoolEnd, breaking the currently implemented logic for matching to HLT objects (more details in PR Fix trigger matching issues in L1Trigger DQMOffline #39691)
  • Offline Tau experts have removed the anti-electron discriminators that are used as input to the Tau DQM code. Implemented a quick fix so that they are simply removed from the offline tau requirements if they do not exist.
    Added more details to warning messages regarding the non-existence of tau discriminators.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport for #41170. Needed for deployment to P5 and to be used for the upcoming data taking period.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 20, 2023

A new Pull Request was created by @vukasinmilosevic (Vukasin Milosevic) for CMSSW_13_0_X.

It involves the following packages:

  • DQMOffline/L1Trigger (dqm, l1)

@aloeliger, @epalencia, @emanueleusai, @cmsbuild, @syuvivida, @pmandrik, @micsucmed, @cecilecaillol, @rvenditti can you please review it and eventually sign? Thanks.
@missirol, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@aloeliger
Copy link
Contributor

Backport of #41170

@aloeliger
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a65f2f/32068/summary.html
COMMIT: af93e92
CMSSW: CMSSW_13_0_X_2023-04-20-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41381/32068/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 22 lines from the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3554298
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3554271
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@aloeliger
Copy link
Contributor

+l1

@vukasinmilosevic
Copy link
Contributor Author

ping @emanueleusai @rvenditti

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b300ac3 into cms-sw:CMSSW_13_0_X Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants