Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DQM perLS in one shot (part 2) #41375

Merged
merged 2 commits into from
Apr 25, 2023
Merged

DQM perLS in one shot (part 2) #41375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23623b7
Suggestion by Matti Kortelainen
jfernan2 Apr 14, 2023
d1f49f5
Code format
jfernan2 Apr 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions DQMServices/Core/interface/DQMStore.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -751,6 +751,8 @@ namespace dqm {
void printTrace(std::string const& message);
// print a log message if ME matches trackME_.
void debugTrackME(const char* message, MonitorElement* me_local, MonitorElement* me_global) const;
// accesor to keep MEsToSave_ private
const auto& getMEsToSave() const { return MEsToSave_; }

private:
// MEComparison is a name-only comparison on MEs and Paths, allowing
Expand Down Expand Up @@ -792,14 +794,12 @@ namespace dqm {

// Book MEs by lumi by default whenever possible.
bool doSaveByLumi_;
// Book MEs by lumi from list in DQMServices/Core/python/DQMStore_cfi.py
std::vector<std::string> MEsToSave_; //just if perLS is ON

// if non-empty, debugTrackME calls will log some information whenever a
// ME path contains this string.
std::string trackME_;

public:
// Book MEs by lumi from list in DQMServices/Core/python/DQMStore_cfi.py
std::vector<std::string> MEsToSave_; //just if perLS is ON
};
} // namespace implementation

Expand Down
6 changes: 4 additions & 2 deletions DQMServices/Core/src/DQMStore.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,11 @@ namespace dqm::implementation {
medata.key_.path_ = path;
medata.key_.kind_ = kind;

if (not store_->MEsToSave_.empty()) {
const auto& MEs = store_->getMEsToSave();

if (not MEs.empty()) {
bool pathInList = false;
for (auto& thepath : store_->MEsToSave_) {
for (const auto& thepath : MEs) {
if (fullpath == thepath) {
medata.key_.scope_ = MonitorElementData::Scope::LUMI;
pathInList = true;
Expand Down