Ecal CC timing reconstruction deployment #41353

jking79 · 2023-04-16T23:15:33Z

PR description:

PR for deployment of ECAL CC timing reconstruction part 2

encoding the non corrected CC in the 8 bit Timing Error:
More details https://indico.cern.ch/event/1210633/contributions/5091427/attachments/2527245/4347248/ECAL_2022_timeError.pdf
Added encoding constants declaration to EcalConstants.h
Added functions to set and return non corrected time to EcalUncalibratedRecHit.h & EcalUncalibratedRecHit.cc
Added function to return non corrected time to EcalRecHit.h

Modified ecalMultiFitUncalibRecHit_cfi.py to make crossCorrelationMethod default timing reconstruction
More details: https://indico.cern.ch/event/1114550/contributions/4887537/attachments/2451361/4200675/ECAL_DPG_25May22.pdf

PR validation:

scram b runtests and runTheMatrix.py -l limited -i all --ibeos test where successfully completed.

…ake CC algo defalut, add encoding of nonCorrected time in jitter error bits via accessor functions.

…f clock units

…for endcoded time check is in ns units.

…ence outside encodable range

…stants.h in namespace ecalcctiming modified: DataFormats/EcalDigi/interface/EcalConstants.h modified: DataFormats/EcalRecHit/interface/EcalRecHit.h modified: DataFormats/EcalRecHit/src/EcalUncalibratedRecHit.cc modified: RecoLocalCalo/EcalRecProducers/plugins/EcalUncalibRecHitWorkerMultiFit.cc modified: RecoLocalCalo/EcalRecProducers/test/testEcalUncalibRechitProducerWithCC_cfg.py

cmsbuild · 2023-04-16T23:24:12Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41353/35191

This PR adds an extra 40KB to repository

cmsbuild · 2023-04-16T23:24:37Z

A new Pull Request was created by @jking79 (Jack W King III) for master.

It involves the following packages:

.gitignore (core)
DataFormats/EcalDigi (simulation)
DataFormats/EcalRecHit (reconstruction)
RecoLocalCalo/EcalRecProducers (reconstruction)

@smuzaffar, @civanch, @Dr15Jones, @makortel, @clacaputo, @cmsbuild, @mdhildreth, @mandrenguyen can you please review it and eventually sign? Thanks.
@youyingli, @missirol, @rchatter, @rovere, @argiro, @apsallid, @thomreis, @wang0jin this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

thomreis · 2023-04-17T08:23:18Z

type ecal

thomreis · 2023-04-17T08:24:14Z

HI @jking79 please restore the original .gitignore file from CMSSW.

cmsbuild · 2023-04-17T16:42:16Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41353/35205

This PR adds an extra 40KB to repository
Found files with invalid states:
- .gitignore:
  - Modified: fd95578
  - Deleted: 9f51e59
  - Added: a92d62a

cmsbuild · 2023-04-17T16:42:45Z

Pull request #41353 was updated. @smuzaffar, @civanch, @Dr15Jones, @makortel, @clacaputo, @cmsbuild, @mdhildreth, @mandrenguyen can you please check and sign again.

cmsbuild · 2023-04-27T17:44:55Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b09f9/32198/summary.html
COMMIT: e51ce77
CMSSW: CMSSW_13_1_X_2023-04-27-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41353/32198/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 435 lines from the logs
Reco comparison results: 26099 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3460685
DQMHistoTests: Total failures: 2942
DQMHistoTests: Total nulls: 6
DQMHistoTests: Total successes: 3457715
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.023 KiB( 47 files compared)
DQMHistoSizes: changed ( 4.53 ): 0.023 KiB JetMET/SUSYDQM
Checked 207 log files, 159 edm output root files, 48 DQM output files
TriggerResults: found differences in 2 / 46 workflows

civanch · 2023-04-28T16:33:44Z

+1

clacaputo · 2023-05-01T13:33:40Z

+reconstruction

cmsbuild · 2023-05-01T13:34:08Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2023-05-02T08:17:23Z

please test
(just to have a look at the outpput of the static checks, here missing)

cmsbuild · 2023-05-02T12:30:30Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b09f9/32290/summary.html
COMMIT: e51ce77
CMSSW: CMSSW_13_1_X_2023-05-01-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41353/32290/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

1002.31002.3_RunZeroBias2022B/step2_RunZeroBias2022B.log
11846.011846.0_ZEE_14+2021PU/step2_ZEE_14+2021PU.log
20834.020834.0_TTbar_14TeV+2026D88/step2_TTbar_14TeV+2026D88.log

Expand to see more relval errors ...

Comparison Summary

Summary:

You potentially removed 438 lines from the logs
Reco comparison results: 26100 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3460877
DQMHistoTests: Total failures: 2924
DQMHistoTests: Total nulls: 6
DQMHistoTests: Total successes: 3457925
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.023 KiB( 47 files compared)
DQMHistoSizes: changed ( 4.53 ): 0.023 KiB JetMET/SUSYDQM
Checked 207 log files, 159 edm output root files, 48 DQM output files
TriggerResults: found differences in 2 / 46 workflows

mandrenguyen · 2023-05-02T15:37:23Z

@perrotta
Do we bother to retrigger the tests?

perrotta · 2023-05-02T17:11:37Z

+1

perrotta · 2023-05-02T17:12:21Z

merge

jking79 added 6 commits April 14, 2023 18:06

ecalTiming CC Deployment: Modified ecalMultiFitUncalibRecHit_cfi to m…

824ad50

…ake CC algo defalut, add encoding of nonCorrected time in jitter error bits via accessor functions.

Modified nonCorrectedTime() in EcalRecHit.h to use ns units instead o…

e4e0d36

…f clock units

modified EcalUncalibRecHitWorkerMultiFit.cc so that LogError message …

8899f30

…for endcoded time check is in ns units.

Modifided nonCorrectedTime() function to return -30.0 when time diffr…

fd95578

…ence outside encodable range

Applied scram build code-format

19b60ae

cmsbuild added this to the CMSSW_13_1_X milestone Apr 16, 2023

cmsbuild added reconstruction-pending simulation-pending core-pending pending-signatures tests-pending orp-pending code-checks-pending labels Apr 16, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 16, 2023

cmsbuild added the ecal label Apr 17, 2023

cmsbuild added code-checks-pending and removed code-checks-approved labels Apr 17, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 17, 2023

cmsbuild added code-checks-pending and removed core-pending code-checks-approved labels Apr 17, 2023

cmsbuild added tests-started and removed tests-pending labels Apr 27, 2023

cmsbuild added tests-approved and removed tests-started labels Apr 27, 2023

cmsbuild added simulation-approved and removed simulation-pending labels Apr 28, 2023

cmsbuild added reconstruction-approved fully-signed and removed reconstruction-pending pending-signatures labels May 1, 2023

cmsbuild added tests-started and removed tests-approved labels May 2, 2023

cmsbuild added tests-rejected and removed tests-started labels May 2, 2023

cmsbuild added orp-approved and removed orp-pending labels May 2, 2023

cmsbuild merged commit 808c6ec into cms-sw:master May 2, 2023

jking79 deleted the ecalTiming_cc_deployment_13_0_0 branch May 2, 2023 18:58

This was referenced May 3, 2023

Introduce (Robust)ParTAK4 jet tagger, DeepJet model update for Run 3, remove DeepCSV from nano #41275

Merged

Fix for llvm-static checks cms-sw/cmsdist#8487

Merged

Add unit test for FEDRawDataCollection format #41494

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ecal CC timing reconstruction deployment #41353

Ecal CC timing reconstruction deployment #41353

jking79 commented Apr 16, 2023

cmsbuild commented Apr 16, 2023

cmsbuild commented Apr 16, 2023

thomreis commented Apr 17, 2023

thomreis commented Apr 17, 2023

cmsbuild commented Apr 17, 2023

cmsbuild commented Apr 17, 2023

cmsbuild commented Apr 27, 2023

civanch commented Apr 28, 2023

clacaputo commented May 1, 2023

cmsbuild commented May 1, 2023

perrotta commented May 2, 2023

cmsbuild commented May 2, 2023

mandrenguyen commented May 2, 2023

perrotta commented May 2, 2023

perrotta commented May 2, 2023

Ecal CC timing reconstruction deployment #41353

Ecal CC timing reconstruction deployment #41353

Conversation

jking79 commented Apr 16, 2023

PR description:

PR validation:

cmsbuild commented Apr 16, 2023

cmsbuild commented Apr 16, 2023

thomreis commented Apr 17, 2023

thomreis commented Apr 17, 2023

cmsbuild commented Apr 17, 2023

cmsbuild commented Apr 17, 2023

cmsbuild commented Apr 27, 2023

Comparison Summary

civanch commented Apr 28, 2023

clacaputo commented May 1, 2023

cmsbuild commented May 1, 2023

perrotta commented May 2, 2023

cmsbuild commented May 2, 2023

RelVals-INPUT

Comparison Summary

mandrenguyen commented May 2, 2023

perrotta commented May 2, 2023

perrotta commented May 2, 2023