-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch and rethrow xml exceptions in TotemDAQMappingESSourceXML #41329
Catch and rethrow xml exceptions in TotemDAQMappingESSourceXML #41329
Conversation
The exceptions are converted to cms::Exceptions.
@makortel FYI |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41329/35156
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages:
@cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
@Dr15Jones You wrote that |
The failure was seen in with the only error message being
The reason I made this PR is so we could actually see the error message. |
Its interesting, am I correct the error seems to appear only in last IB and only for specific architecture (fails on aarch64, works on amd64) ? |
Yes, only in the latest IB, only for aarch64. And I have tried reproducing the failure locally, but could not. |
-1 Failed Tests: RelVals-INPUT RelVals-INPUTThe relvals timed out after 4 hours. Comparison SummarySummary:
|
@cmsbuild , please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-47f670/31958/summary.html Comparison SummarySummary:
|
@cmsbuild , please test for el9_aarch64_gcc11 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-47f670/31959/summary.html |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The exceptions are converted to cms::Exceptions.
Unknown exceptions were seen from this code in the IBs.
PR validation:
Code compiles.