Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_0_X] Pixel Alpaka Migration: Modification to Existing Modules [I] #41283

Merged

Conversation

AdrianoDee
Copy link
Contributor

@AdrianoDee AdrianoDee commented Apr 5, 2023

PR description:

This PR stems from #41117 and it's the 1st of a series of smaller PRs for 13_0_X.

This is It includes the changes to pre-existing modules or headers (BuildFiles not included here).
A single real change to include the max number of hits in the the topologies.

A backport of #41282.

This will change depending on #41223.

PR validation:

It compiles. Running base tests. No regression expected.

Co-authored-by: Adriano Di Florio <[email protected]>
Co-authored-by: Breno Orzari <[email protected]>
Co-authored-by: Dimitris Papagiannis <[email protected]>
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2023

A new Pull Request was created by @AdrianoDee (Adriano Di Florio) for CMSSW_13_0_X.

It involves the following packages:

  • Geometry/CommonTopologies (geometry)
  • RecoPixelVertexing/PixelTrackFitting (reconstruction)
  • RecoPixelVertexing/PixelTriplets (reconstruction)

@civanch, @Dr15Jones, @makortel, @clacaputo, @cmsbuild, @bsunanda, @mdhildreth, @mandrenguyen can you please review it and eventually sign? Thanks.
@fabiocos, @VourMa, @bsunanda, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @missirol, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Apr 7, 2023

backport of #41282

@fwyzard
Copy link
Contributor

fwyzard commented Apr 14, 2023

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a5662a/31981/summary.html
COMMIT: 1743a19
CMSSW: CMSSW_13_0_X_2023-04-13-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41283/31981/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 14 lines to the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3554298
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3554270
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@clacaputo
Copy link
Contributor

clacaputo commented Apr 17, 2023

@civanch
Copy link
Contributor

civanch commented Apr 19, 2023

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c09a56d into cms-sw:CMSSW_13_0_X Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants