Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ap_data type to Phase 2 GMT output for GT interface #41277

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Add ap_data type to Phase 2 GMT output for GT interface #41277

merged 1 commit into from
Apr 5, 2023

Conversation

zhenbinwu
Copy link
Contributor

PR description:

  1. Added the ap_data type in the Phase2 GMT output dataformat, as requested by the GT group.
  2. Update the GMT Z0/D0 LSB

Add ap_data type for GT interface
af2de82 
Update GMT emulator for new ap format

Also clean up the config file

Update Z0/D0 according to GT

Using 0.05 for Z0 and 0.03 for d0.

update code format

Bug fix in tracker muon matching

Thanks to Santi for spotting this. This line was commented out by
someone, likely by accident.

Update the reference type to SA muons
@cmsbuild cmsbuild added this to the CMSSW_13_1_X milestone Apr 4, 2023
@zhenbinwu zhenbinwu mentioned this pull request Apr 4, 2023
Merged
@aloeliger
Copy link
Contributor

Corresponds to cms-l1t-offline#1079

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41277/35040

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2023

A new Pull Request was created by @zhenbinwu (Zhenbin Wu) for master.

It involves the following packages:

  • DataFormats/L1TMuonPhase2 (l1)
  • L1Trigger/Phase2L1GMT (l1)

@epalencia, @cmsbuild, @cecilecaillol, @aloeliger can you please review it and eventually sign? Thanks.
@JanFSchulte, @rovere, @eyigitba, @Martin-Grunewald, @missirol, @thomreis, @dinyar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@aloeliger
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2023

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-adbf64/31813/summary.html
COMMIT: af2de82
CMSSW: CMSSW_13_1_X_2023-04-04-1600/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41277/31813/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 47
  • DQMHistoTests: Total histograms compared: 3365163
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3365134
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
  • Checked 202 log files, 155 edm output root files, 47 DQM output files
  • TriggerResults: no differences found

@aloeliger
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-adbf64/31827/summary.html
COMMIT: af2de82
CMSSW: CMSSW_13_1_X_2023-04-04-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41277/31827/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 47
  • DQMHistoTests: Total histograms compared: 3365163
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3365134
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
  • Checked 202 log files, 155 edm output root files, 47 DQM output files
  • TriggerResults: no differences found

@aloeliger
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 11f462c into cms-sw:master Apr 5, 2023
perrotta
perrotta reviewed Apr 5, 2023
View reviewed changes
DataFormats/L1TMuonPhase2/src/classes_def.xml
@@ -8,8 +8,8 @@
<class name="edm::Wrapper<std::vector<l1t::MuonStub > >"/>
<class name="edm::Ref<l1t::MuonStubCollection>" splitLevel="0"/>

<class name="l1t::TrackerMuon" ClassVersion="3">
<version ClassVersion="3" checksum="2397458791"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not remove previous versions!

   <version ClassVersion="3" checksum="2397458791"/>

must be left below ClassVersion="4" here below.

A fix is in order as soon as next 2300 IB will become available

Copy link
Contributor

@aloeliger aloeliger Apr 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies, I should have caught this. I can prepare a fix for this immediately as of the next IB.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix prepared in #41293: thank you @aloeliger !

This was referenced Apr 5, 2023
Merged
Merged
@aloeliger aloeliger mentioned this pull request Apr 6, 2023
Merged
cmsbuild added a commit that referenced this pull request Apr 6, 2023
@cmsbuild
Merge pull request #41293 from aloeliger/MuonClassDefFix
e6d78ea 
Add back data version removed in #41277
This was referenced Apr 6, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloeliger aloeliger aloeliger left review comments

@perrotta perrotta perrotta left review comments

Assignees
No one assigned
Labels
code-checks-approved fully-signed l1-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_13_1_X
Development

Successfully merging this pull request may close these issues.
5 participants
@zhenbinwu @aloeliger @cmsbuild @rappoccio @perrotta