Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1 nano: 13_0_X backport #41245

Merged
merged 12 commits into from
Apr 2, 2023
Merged

L1 nano: 13_0_X backport #41245

merged 12 commits into from
Apr 2, 2023

Conversation

Sam-Harper
Copy link
Contributor

PR description:

This PR is a backport of #40663 which adds L1 information to NanoAOD.

It is necessary to backport to be able to run as prompt nano this year.

PR validation:

Validation is covered in the original PR
#40663 (its the exact same branch, merges in both 13_0_X and 13_1_X)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Sam-Harper (Sam Harper) for CMSSW_13_0_X.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • PhysicsTools/NanoAOD (xpog)

@swertz, @vlimant, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @simonepigazzini, @sunilUIET can you please review it and eventually sign? Thanks.
@makortel, @AnnikaStein, @kpedro88, @Martin-Grunewald, @missirol, @gpetruc, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@swertz
Copy link
Contributor

swertz commented Mar 31, 2023

enable nano

@swertz
Copy link
Contributor

swertz commented Mar 31, 2023

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-87b78b/31710/summary.html
COMMIT: e1c084e
CMSSW: CMSSW_13_0_X_2023-03-31-1100/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41245/31710/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3554479
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3554450
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially removed 4 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 10777
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 10777
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
  • Checked 23 log files, 10 edm output root files, 11 DQM output files

Nano size comparison Summary:

  • Nano ERROR: Missing ref/2500.5111-size.json
  • Nano ERROR: Missing ref/2500.5111-size.json
    | Sample | kb/ev | ref kb/ev | diff kb/ev | ev/s/thd | ref ev/s/thd | diff rate | mem/thd | ref mem/thd |
    | --- | --- | --- | --- | --- | --- | --- | --- | --- |
    | 2500.31 | 2.223 | 2.223 | 0.000 ( +0.0% ) | 9.69 | 9.77 | -0.8% | 1.441 | 1.501 |
    | 2500.311 | 2.322 | 2.322 | 0.000 ( +0.0% ) | 9.26 | 9.33 | -0.8% | 1.732 | 1.876 |
    | 2500.312 | 2.275 | 2.275 | 0.000 ( +0.0% ) | 9.37 | 9.48 | -1.1% | 1.726 | 1.870 |
    | 2500.33 | 1.098 | 1.098 | 0.000 ( +0.0% ) | 21.92 | 22.39 | -2.1% | 1.582 | 1.634 |
    | 2500.331 | 1.392 | 1.392 | 0.000 ( +0.0% ) | 16.17 | 16.22 | -0.3% | 1.605 | 1.781 |
    | 2500.332 | 1.324 | 1.324 | 0.000 ( +0.0% ) | 18.05 | 17.97 | +0.5% | 1.534 | 1.823 |
    | 2500.401 | 2.137 | 2.137 | 0.000 ( +0.0% ) | 10.49 | 10.61 | -1.2% | 1.138 | 1.208 |
    | 2500.501 | 1.710 | 1.710 | 0.000 ( +0.0% ) | 16.57 | 16.36 | +1.2% | 1.089 | 1.118 |
    | 2500.511 | 1.122 | 1.122 | 0.000 ( +0.0% ) | 30.97 | 30.90 | +0.2% | 1.331 | 1.360 |
    | 2500.601 | 2.049 | 2.049 | 0.000 ( +0.0% ) | 12.54 | 12.54 | -0.0% | 1.069 | 1.178 |

@swertz
Copy link
Contributor

swertz commented Mar 31, 2023

+xpog

Vertbatim backport; needed for prompt data NanoV12

@srimanob
Copy link
Contributor

srimanob commented Apr 1, 2023

+Upgrade

@kskovpen
Copy link
Contributor

kskovpen commented Apr 1, 2023

+pdmv

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Apr 2, 2023

+1

@cmsbuild cmsbuild merged commit 5f9e670 into cms-sw:CMSSW_13_0_X Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants