Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(13_0_X) updated HMT loose thresholds backport #41197

Merged
merged 1 commit into from
Mar 28, 2023
Merged

(13_0_X) updated HMT loose thresholds backport #41197

merged 1 commit into from
Mar 28, 2023

Conversation

fmanteca
Copy link
Contributor

PR description:

This PR is a backport of #41192

Update HMT loose shower thresholds to values corresponding to 2023 data taking, needed for 2023 run preparation.

Need to backport to CMSSW_13_0_X to be able to test the new loose HMT shower configuration at p5, which is a completely new functionality. The information is propagated through the different subsystems (CSC->EMTF->uGMT->uGT), up to build the new L1 seed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 27, 2023

A new Pull Request was created by @fmanteca (Pedro J. Fernndez Manteca) for CMSSW_13_0_X.

It involves the following packages:

  • L1Trigger/CSCTriggerPrimitives (l1)

@epalencia, @cmsbuild, @cecilecaillol, @aloeliger can you please review it and eventually sign? Thanks.
@giovanni-mocellin, @JanFSchulte, @eyigitba, @Martin-Grunewald, @missirol, @ptcox, @valuev this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@epalencia
Copy link
Contributor

Please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b6c1e3/31624/summary.html
COMMIT: bd2dd44
CMSSW: CMSSW_13_0_X_2023-03-27-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41197/31624/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 20 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3554529
  • DQMHistoTests: Total failures: 26
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3554481
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@epalencia
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

backport of #41192

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4908ace into cms-sw:CMSSW_13_0_X Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants