Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upper cut on jet time to HLTJetTimingFilter [13_0_X] #41179

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

missirol
Copy link
Contributor

@missirol missirol commented Mar 24, 2023

backport of #41177

Attn: @ssantpur

PR description:

From the description of #41089:

This PR allows for more flexibility in choosing the timing thresholds for the delayed jet and delayed E/gamma triggers, this does not effect any existing triggers or their rates. The modification is to enable triggering on the negative timing region that can target beam halo and satellite collisions, and allow for maximum timing to be specified in the positive timing side to enable some delayed jet triggers to be added to parking dataset.

PR validation:

From the description of #41089:

I ran over HLTPhysics using Run2022G dataset and saw no change in the rates.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

#41177

Development of Run-3 HLT menus for 2023 data-taking and Run-3 MC.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 24, 2023

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_13_0_X.

It involves the following packages:

  • HLTrigger/JetMET (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-066bb3/31582/summary.html
COMMIT: 2c0eb4e
CMSSW: CMSSW_13_0_X_2023-03-24-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41179/31582/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 8 lines to the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3554529
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3554501
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@ssantpur
Copy link

@missirol Let me know if there is anything that needs to be done before merging this into CMSSW. The HLT v1.0 deadline is this weekend and we would like to push delayed jet triggers before that, if possible. Thanks in advance.

@missirol
Copy link
Contributor Author

The HLT v1.0 deadline is this weekend

Incorrect. The deadline to file requests for "V1.0" was March 8th, see recent TSG News (slide 5).

and we would like to push delayed jet triggers before that, if possible.

There is some misunderstanding about timelines here. Even if this PR gets merged today, the new version of the plugin won't be available until a new CMSSW release is built; only after that happens, a ConfDB template for said new release will be available to implement triggers with the new version of the plugin. All this won't happen by Monday, which is when we will cut the "V1.0" menu, unless TSG decides otherwise. (cc: @silviodonato)

@missirol
Copy link
Contributor Author

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2fddc06 into cms-sw:CMSSW_13_0_X Mar 27, 2023
@missirol missirol deleted the TwoSidedTimingFilter branch May 13, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants