-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use start time of cmsRun in CondorStatusService #41165
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41165/34836
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
be84e25
to
980f46e
Compare
please test |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41165/34838
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
980f46e
to
8f88997
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41165/34850
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages:
@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
Use the information in the timing service to get the start time of cmsRun and use that time to calculate job duration.
7339963
to
0886587
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41165/34889
|
Pull request #41165 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ba1489/31617/summary.html Comparison SummarySummary:
|
+core |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Use the information in the timing service to get the start time of cmsRun and use that time to calculate job duration.
Previously the time as of the begin job transition was used but this misses all the initialization time. As the CPU time reported is for the job as a whole this change now allows for better CPU efficiency calculations.
PR validation:
Code compiles.