-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for nanoGEN jets #41163
Fix for nanoGEN jets #41163
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41163/34822
|
A new Pull Request was created by @Cvico (Carlos Vico Villalba) for master. It involves the following packages:
@cmsbuild, @simonepigazzini, @swertz, @vlimant can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18d7ca/31577/summary.html Comparison SummarySummary:
|
Thanks @Cvico, it's nice to see this bug finally corrected. |
+1 Thanks! Perhaps it could be good to also backport this to 13_0_X, in case people will use the same release for NanoGEN and NanoAOD v12... |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Hi. Thanks for merging my PR!. Regarding the comment from @swertz, |
Yes, I think it would be good to fix in 13_0 as well. Thanks! |
PR description
This PR includes a minimal change in the configuration file that is used for producing NanoGEN format:
PhysicsTools/NanoAOD/python/nanogen_cff.py
.Additional information
This issue has been known for some time, but it was never fixed and included in the master branch up until know. Everything regarding this issue is discussed in 1 and 2.
I'm adding @kdlong in the thread (since he is the one that told me the issue) just in case there's any other detail I might be leaving out. The changes to the central code should have 0 impact (just change the object that is used for computing generation jets), but the physics impact should be quite relevant specially for those analyses that use NanoGEN information for comparing generation jets between nanoGEN and nanoAOD.
References