Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update autoSkim for 2023 data taking [13_1_X] #41145

Merged
merged 3 commits into from
Apr 11, 2023

Conversation

youyingli
Copy link
Contributor

@youyingli youyingli commented Mar 23, 2023

PR description:

Update new PDs to support the skim for 2023 data taking. The update follows the following:

Update the skim workflow to fit the 2023 skim config

PR validation:

N/A

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild cmsbuild added this to the CMSSW_13_1_X milestone Mar 23, 2023
@youyingli youyingli changed the title Update autoSkim for 2023 data taking Update autoSkim for 2023 data taking [13_1_X] Mar 23, 2023
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41145/34794

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @youyingli (You-Ying Li) for master.

It involves the following packages:

  • Configuration/Skimming (pdmv)

@cmsbuild, @bbilin, @sunilUIET, @kskovpen can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41145/35090

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2023

Pull request #41145 was updated. @perrotta, @rappoccio, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @sunilUIET, @fabiocos, @davidlange6 can you please check and sign again.

@kskovpen
Copy link
Contributor

kskovpen commented Apr 6, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22ecb4/31865/summary.html
COMMIT: bfb08c2
CMSSW: CMSSW_13_1_X_2023-04-05-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41145/31865/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22ecb4/31865/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22ecb4/31865/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3459609
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3459587
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

@kskovpen @srimanob is there any reason why you only signed the 13_0_X backport, and not this PR submitted for master? Can I give your signature for granted also here?

@kskovpen
Copy link
Contributor

+pdmv

@kskovpen
Copy link
Contributor

@kskovpen @srimanob is there any reason why you only signed the 13_0_X backport, and not this PR submitted for master? Can I give your signature for granted also here?

signed :)

@perrotta
Copy link
Contributor

+operations

@perrotta
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants