Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTD digitization: Add calculation of per SiPM time resolution to BtlElectronicsSim #41131

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

fabiocos
Copy link
Contributor

PR description:

This PR makes more explicit in the code the different components of the BTL time resolution model used so far, in order to easily relates detectors studies and the existing CMSSW implementation. This is based on an older study documented in
https://indico.cern.ch/event/1106612/contributions/4659237/attachments/2366975/4041918/BTLresolution_20211217.pdf
In this PR the model is not changed, but there is some minor code cleaning, and an optional LogDebug printout providing reference values used:

%MSG-d BTLElectronicsSim:  MixingModule:mix@ctor 22-Mar-2023 17:32:34 CET  pre-events BTLElectronicsSim.cc:60
 BTL time resolution model (ns, 1 SiPM), for an average light output of    8400.000000 N_pe:
 sigma stochastic   =       0.046840
 sigma DCR          =       0.015793
 sigma electronics  =       0.004762
 sigma sptr         =       0.013416
 sigma clock        =       0.015000
 ---------------------
 sigma total        =       0.053583
%MSG

PR validation:

This code has been used to produce 10 events with test workflow 20834.0 (TTbar noPU scenario D88), whose BTL digi dump https://github.com/cms-sw/cmssw/blob/master/SimGeneral/Debugging/test/SimDigiDumper.cc#L421 is identical to the default one.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41131/34780

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

  • SimFastTiming/FastTimingCommon (upgrade, simulation)

@cmsbuild, @AdrianoDee, @srimanob, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da6848/31518/summary.html
COMMIT: 1c72394
CMSSW: CMSSW_13_1_X_2023-03-22-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41131/31518/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 10 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3552750
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3552725
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Mar 22, 2023

+1

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants