-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MTD digitization: Add calculation of per SiPM time resolution to BtlElectronicsSim #41131
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41131/34780
|
A new Pull Request was created by @fabiocos (Fabio Cossutti) for master. It involves the following packages:
@cmsbuild, @AdrianoDee, @srimanob, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da6848/31518/summary.html Comparison SummarySummary:
|
+1 |
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR makes more explicit in the code the different components of the BTL time resolution model used so far, in order to easily relates detectors studies and the existing CMSSW implementation. This is based on an older study documented in
https://indico.cern.ch/event/1106612/contributions/4659237/attachments/2366975/4041918/BTLresolution_20211217.pdf
In this PR the model is not changed, but there is some minor code cleaning, and an optional
LogDebug
printout providing reference values used:PR validation:
This code has been used to produce 10 events with test workflow 20834.0 (TTbar noPU scenario D88), whose BTL digi dump https://github.com/cms-sw/cmssw/blob/master/SimGeneral/Debugging/test/SimDigiDumper.cc#L421 is identical to the default one.