Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 13_0_X (5/N) [13_1_X] #41113

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

missirol
Copy link
Contributor

PR description:

Development of HLT menus for CMSSW_13_0_X.

This is the PR for the master branch, which will then be backported to 13_0_X (the latter is the release cycle currently used for Run-3 HLT-menu development).

It includes the integration of the following JIRA tickets.

  • CMSHLT-2587: [HCAL,CSC,GEM] sync hcalRecAlgos and muonDetIdAssociator ES modules with Run-3 offline reco
  • CMSHLT-2635: [BPH] use pixel-triplet matching in low-mass di-electron triggers
  • CMSHLT-2637: [BPH] use pixel-triplet matching in HLT_SingleEle* control triggers
  • CMSHLT-2651: [DAQ] changed compression settings of all OutputModules to (algorithm = "ZSTD", level = 3)
  • CMSHLT-2684: [HIG] triggers for HH4b in semi-resolved topology
  • CMSHLT-2685: [HIG] added PNet-based VBF HToCC triggers
  • CMSHLT-2688: [BPH] added 2023 L1T seeds to BsMuMu triggers (part 2)
  • CMSHLT-2689: [JME] halved PSs of HLT_PFJetFwd80 and HLT_AK8PFJetFwd80 (part 2)
  • CMSHLT-2694: [B2G] added backups of AK8(Di,)PFJet*_MassSD(30,50) triggers
  • CMSHLT-2696: [TSG] store unseeded E/gamma in Scouting, and use separate L1EG-seeded Scouting triggers
  • CMSHLT-2698: [BPH] removal of four Dimuon0_Upsilon triggers from GRun (combined table unchanged)
  • CMSHLT-2701: [JME] additional HLT_Photon*EB_TightID_TightIso triggers
  • CMSHLT-2707: [EXO] moved MuShower-seeded DT/CSC-cluster triggers to Muon PD
  • CMSHLT-2721: [BPH] set PS=0 for HLT_Mu12_IP6_v and remove ParkingSingleMuon* streams/PDs from GRun
  • CMSHLT-2724: [EXO] added HLT-HT cut to L1_Mu6HT240-seeded displaced-jets triggers
  • CMSHLT-2726: [EGM] removed *ForBParking* Sequences from MC_Egamma_Open* triggers, and add MC_Egamma_Open* to GRun menu

PR validation:

TSG tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

CMSSW_13_0_X

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41113/34747

  • This PR adds an extra 804KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

test parameters:

  • workflows = 139.004,140.003,140.023,140.043,140.063,12634.0,12634.99,12834.0,13034.0,13034.99

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c04d34/31470/summary.html
COMMIT: 376cce0
CMSSW: CMSSW_13_1_X_2023-03-20-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41113/31470/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 4.674.67_ZElSkim2012C/step2_ZElSkim2012C.log

Comparison Summary

Summary:

  • You potentially added 8 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 92 differences found in the comparisons
  • DQMHistoTests: Total files compared: 59
  • DQMHistoTests: Total histograms compared: 4775617
  • DQMHistoTests: Total failures: 2506
  • DQMHistoTests: Total nulls: 1099
  • DQMHistoTests: Total successes: 4771990
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 8202.257999999998 KiB( 58 files compared)
  • DQMHistoSizes: changed ( 12434.0,... ): 436.348 KiB HLT/JME
  • DQMHistoSizes: changed ( 12434.0,... ): 169.730 KiB HLT/HLTEgammaValidation
  • DQMHistoSizes: changed ( 12434.0,... ): 157.263 KiB HLT/EGM
  • DQMHistoSizes: changed ( 12434.0,... ): 5.046 KiB HLT/Filters
  • Checked 256 log files, 206 edm output root files, 59 DQM output files
  • TriggerResults: found differences in 12 / 57 workflows

@missirol
Copy link
Contributor Author

Wf 4.67 failed with [1], but the file is present in the cmsbot cache as usual, and I can access it locally. This looks like a transient issue, unrelated to this PR.

[1]

Failed to open file at URL root://eoscms.cern.ch:1094//eos/cms/store/user/cmsbuild/store/data/Run2012C/DoubleElectron/RAW-RECO/ZElectron-22Jan2013-v1/20000/02C8CD56-BF68-E211-9057-003048679182.root?xrdcl.requuid=d1ff2322-8f6c-4313-a65b-5f9937f06c24.

@missirol
Copy link
Contributor Author

missirol commented Mar 21, 2023

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 4c4bee9 into cms-sw:master Mar 21, 2023
@missirol missirol deleted the HLTdevelopment130X_for131X branch March 21, 2023 17:18
@missirol
Copy link
Contributor Author

missirol commented Mar 22, 2023

After this PR was merged, the HLT-Validation tests of the CMSSW_13_1_X_2023-03-21-2300 IB failed [1].

On the other hand, the errors [2] [3] seem unrelated to the PR; they look like transient failures in accessing files:

Failed to open file at URL root://eoscms.cern.ch:1094//eos/cms/store/user/cmsbuild/store/relval/CMSSW_12_3_0_pre6/RelValTTbar_14TeV/GEN-SIM/123X_mcRun3_2021_realistic_v11-v1/10000/29297788-21c3-4bf2-afe0-5382f08fbcd5.root?tried=&xrdcl.requuid=0265148c-57ad-495d-bec6-cc74de8bebf1.

[..]

Failed to open file at URL root://eoscms.cern.ch:1094//eos/cms/store/user/cmsbuild/store/relval/CMSSW_12_3_0_pre6/RelValTTbar_14TeV/GEN-SIM/123X_mcRun3_2021_realistic_v11-v1/10000/29297788-21c3-4bf2-afe0-5382f08fbcd5.root?tried=&xrdcl.requuid=c98b28a9-0272-41d9-926d-658d7acd9418.

This is somewhat similar to the transient errors seen during the tests of this PR, see #41113 (comment).

(The errors happen to come from the PRef- and PIon-menu tests, and one can see that this PR changed those menus minimally; the same menus passed the "addOnTests" during the PR tests.)

I conclude that this PR is okay, and the backport can be merged (#41114).

Edit: for the record, the HLT-Validation tests passed later on in CMSSW_13_1_X_2023-03-22-1100, which confirms the above guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants